[#45197] - [6.0] Fix frontend module editing
- Fixed in Code Base
- 26 Mar 2025
- Medium
- Build: 6.0-dev
- # 45197
- Diff
- joomdonation:fix_frontend_module_editing
User tests: Successful: Unsuccessful:
Pull Request for Issue #45190.
Summary of Changes
Currently, when you try to edit any module from frontend, there will be fatal error. This PR fixes that error
Testing Instructions
- Use Joomla 6.0 nightly build
- Login to frontend of your site using super user account. Click on edit icon next to any module to edit the module
Actual result BEFORE applying this Pull Request
- You get fatal error
Expected result AFTER applying this Pull Request
- No error. You can see module edit form and can save the change
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules Front End com_config |
I have tested this item ✅ successfully on 6048409
Thanks @joomdonation .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45197.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-6.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45197.
I am very concerned with the need for this PR
`When i see pull requests for j6 that fix core functionality it worries me as there shouldnt be a need for them.
- What has changed to require this?
- Was that change incomplete?
- Was it documented?
If it broke core functionality here then are you sure it hasnt broken core functionality somewhere else and we are not starting a game of whack a mole
If it broke core functionality here then what will happen with extensions.
In short, there have been attempts to remove the usages of deprecated CMSObject class from our core code. The most important one is #42961, it changes return data type of a widely used method getItem of AdminModel from CMSObject to stdClass and it affects not only core code but also third party extensions.
As the return data changed to stdClass, each time that return object call methods such as $data->set('name', 'value'), $data->get('name'), $data->getProperties (these are common cases), fatal error will happen.
And I'm worry about this change, too.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-26 11:31:02 |
| Closed_By | ⇒ | Bodge-IT |
I have tested this item ✅ successfully on 6048409
I have tested this successfully - Thanks @joomdonation! :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45197.