[#45191] - [5.4] Featured Articles Author Column
- Closed
- 27 Mar 2025
- Medium
- Build: 5.3-dev
- # 45191
- Diff
- brianteeman:featured
User tests: Successful: Unsuccessful:
Summary of Changes
There is a check in the Author column to display the author name if the id is not 0 else to display the author as None
I believe this check to be incorrect. When a user is deleted from the users table the created_by in the content table is untouched so the condition in the query is never passed.
This PR changes the condition to check for the author_name in the featured articles and this way we can satisfy the condition and are able to display the author as None
This PR is the same as #45179 but for the featured articles view
Testing Instructions
Create two users
Create featured articles with each user
Delete one of the users
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
@richard67 thanks and corrected
I have tested this item ✅ successfully on 5711649
Test by using the custom update server of the prebuilt packages.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45191.
I have tested this item ✅ successfully on 5711649
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45191.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45191.
| Labels |
Added:
RTC
|
||
Thanks for the PR - I suggest using '- None -' instead of 'None' since its technicallly possible to have a user called 'None' - And to be consistent in the search dropdown we should use the same. In the screenshot i have added a user 'None' and deleted a user beeing the author of an article. (Must not be red...) - and alas is it is even possible to have a user named '- None -'
The dropdown has had "none" for a very long time. It is not added by this PR
And to be even more consistent, 'created my me' could be '- created my me -' so it would make it clear, that this is a 'pseudo' search possibilty
The dropdown has had "none" for a very long time. It is not added by this PR
Yes i know - but you might be able to work on it.
The dropdown has had "none" for a very long time. It is not added by this PR
Yes i know - but you might be able to work on it.
Beyond the scope of this PR as to do it correctly it would need to be changed everywhere
| Title |
|
||||||
| Status | Ready to Commit | ⇒ | Pending | ||||
It was discussed in the maintainers meeting and we decided to move this to 5.4 to give it more time to do it in a way that it covers also possible "strange" user names.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45191.
@rdeutz I fully understand the "strange username" aspect BUT this PR is only to bring the featured articles view in line with the existing articles view. The "strange username" issue is easy to handle but it has a much bigger scope than this simple PR as it has an impact on lots of different places and will require a new language string. In short this PR should be merged as it is and then I will make a new PR to address the "strange username" everywhere that it can appear.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-27 10:09:08 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Removed:
RTC
|
||
@brianteeman I assume you meant #45179 . If that's right, please correct in the Summary of Changes.