User tests: Successful: 0 Unsuccessful: 0
This PR fixes a bug where filtering articles by Author = None did not return articles created by deleted users. Joomla previously used created_by = 0
for the "None" filter, but in reality, deleted users leave their created_by
values intact in the #__content
table — they just no longer exist in the #__users
table.
This fix updates the logic to:
0
(representing "None")created_by NOT IN (SELECT id FROM #__users)
author_id = [0, 42]
, to include both deleted users and existing onescreated_by = 0
was used incorrectly.created_by NOT IN (SELECT id FROM #__users)
for deleted users.Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_content |
Title |
|
Labels |
Added:
PR-5.2-dev
|
I have tested this item ✅ successfully on 66cd254
Thank you for your feedbacks, @fgsw @brianteeman.
great work!!
I have tested this item ✅ successfully on 66cd254
No deleted user
One deleted user
One deleted user
Three deleted user
Status | Pending | ⇒ | Ready to Commit |
Build | 5.2-dev | ⇒ | 5.3-dev |
RTC
Good work with this PR, really like it, just found a minor thing you probably could fix.
Labels |
Added:
RTC
PR-5.3-dev
Removed: PR-5.2-dev |
Title |
|
As agreed today in the maintainers meeting, I've rebased this PR to 5.4-dev.
Labels |
Added:
PR-5.4-dev
|
@AdarshSantoria Please delete "Fix #45181 - " from the title.
The title say [5.3], but the label is PR-5.2-dev.