RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Mar 2025

Summary of Changes

There is a check in the Author column to display the author name if the id is not 0 else to display the author as None

I believe this check to be incorrect. When a user is deleted from the users table the created_by in the content table is untouched so the condition in the query is never passed.

This PR changes the condition to check for the author_name and this way we can satisfy the condition and are able to display the author as None

This PR does not fix the related problem in the authors filter where you can not filter by author None even though it is intended that you can.

This changes in this PR if accepted will need to be applied to all other components with the same condition

Testing Instructions

Create two users
Create articles with each user
Delete one of the users

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 21 Mar 2025
avatar brianteeman brianteeman - change - 21 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2025
Category Administration com_content
avatar brianteeman brianteeman - change - 21 Mar 2025
Labels Added: PR-5.3-dev
avatar fgsw fgsw - test_item - 21 Mar 2025 - Tested successfully
avatar fgsw
fgsw - comment - 21 Mar 2025

I have tested this item ✅ successfully on 270ed2a

Without PR with PR
without with

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45179.
avatar brianteeman brianteeman - change - 21 Mar 2025
The description was changed
avatar brianteeman brianteeman - edited - 21 Mar 2025
avatar ChristineWk ChristineWk - test_item - 22 Mar 2025 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 22 Mar 2025

I have tested this item ✅ successfully on 270ed2a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45179.

avatar richard67 richard67 - change - 22 Mar 2025
The description was changed
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Mar 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45179.

avatar richard67 richard67 - edited - 22 Mar 2025
avatar QuyTon QuyTon - change - 23 Mar 2025
Labels Added: RTC
avatar bembelimen bembelimen - change - 25 Mar 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-03-25 22:58:11
Closed_By bembelimen
avatar bembelimen bembelimen - close - 25 Mar 2025
avatar bembelimen bembelimen - merge - 25 Mar 2025
avatar bembelimen
bembelimen - comment - 25 Mar 2025

Thx

avatar brianteeman
brianteeman - comment - 26 Mar 2025

Thanks

Add a Comment

Login with GitHub to post a comment