PR-5.2-dev PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hemang360
Hemang360
20 Mar 2025

Pull Request for Issue #45173.

Summary of Changes

Fixed an issue where TinyMCE editor presets assigned to specific user groups were not being correctly applied when a user belonged to multiple groups in the hierarchy. The code now prioritizes presets based on group specificity, ensuring the most direct user group's preset takes precedence.

Testing Instructions

  1. Set the default editor to "TinyMCE"
  2. Create a user assigned to Publisher group
  3. Go to System > Plugins > Editor - TinyMCE
  4. Assign "Set 2" to "Publisher" and save
  5. Go to frontend and login as the Publisher user
  6. Edit an article

Actual result BEFORE applying this Pull Request

Screenshot 2025-03-21 021138
TinyMCE loads "Set 0" (the largest set of tools) instead of the assigned "Set 2".

Expected result AFTER applying this Pull Request

Screenshot 2025-03-21 020221
TinyMCE correctly loads "Set 2" (simple set of tools) as assigned to the Publisher group.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hemang360 Hemang360 - open - 20 Mar 2025
avatar Hemang360 Hemang360 - change - 20 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2025
Category Front End Plugins
avatar Hemang360 Hemang360 - change - 20 Mar 2025
The description was changed
avatar Hemang360 Hemang360 - edited - 20 Mar 2025
avatar Hemang360 Hemang360 - change - 20 Mar 2025
The description was changed
avatar Hemang360 Hemang360 - edited - 20 Mar 2025
avatar Hemang360 Hemang360 - change - 20 Mar 2025
Labels Added: PR-5.2-dev
avatar Fedik
Fedik - comment - 21 Mar 2025

All you need is just to place break 2; after this line:

if (isset($ugroups[$group])) {
$extraOptions = $val;
$toolbarParams = (object) $toolbarParamsAll[$set];

avatar brianteeman
brianteeman - comment - 21 Mar 2025

Please rebase this to the 5.3 branch

avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2025
Category Front End Plugins Unit Tests Repository Administration com_admin SQL Postgresql com_associations
avatar Hemang360 Hemang360 - change - 21 Mar 2025
Labels Added: Unit/System Tests
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2025
Category Unit Tests Repository Administration com_admin SQL Postgresql com_associations Front End Plugins
avatar Hemang360
Hemang360 - comment - 21 Mar 2025

@brianteeman I've rebased the PR to the 5.3 branch. Let me know if any further changes are needed.

avatar Hemang360 Hemang360 - change - 21 Mar 2025
Labels Added: PR-5.3-dev
Removed: Unit/System Tests
avatar Fedik Fedik - close - 22 Mar 2025
avatar Fedik
Fedik - comment - 22 Mar 2025

Turns out it was not a bug, I close your PR.
Thanks for effort anyway.

avatar Fedik Fedik - change - 22 Mar 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-03-22 09:03:20
Closed_By Fedik

Add a Comment

Login with GitHub to post a comment