NPM Resource Changed bug PR-5.2-dev PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar fazil-shaik
fazil-shaik
20 Mar 2025

Pull Request for Issue #44957 .

Summary of Changes

Added changes in code of default.php file of adminstartor/components/com_media/tmpl/file/default.php with custom logic for trimming the file name

Actual result BEFORE applying this Pull Request

Trimming of text is full

Expected result AFTER applying this Pull Request

Trimmed the text upto UI/UX view
image
This is the after applying pr result in previous the image is not with me after applying pr the result we get is trimmed text view of image accordance to UI/UX and the code is also optimized and changed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar fazil-shaik fazil-shaik - open - 20 Mar 2025
avatar fazil-shaik fazil-shaik - change - 20 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2025
Category Administration com_media NPM Change
avatar fazil-shaik fazil-shaik - change - 20 Mar 2025
Labels Added: NPM Resource Changed PR-5.2-dev
avatar fazil-shaik fazil-shaik - change - 20 Mar 2025
The description was changed
avatar fazil-shaik fazil-shaik - edited - 20 Mar 2025
avatar fazil-shaik fazil-shaik - change - 20 Mar 2025
The description was changed
avatar fazil-shaik fazil-shaik - edited - 20 Mar 2025
avatar fazil-shaik fazil-shaik - change - 20 Mar 2025
The description was changed
avatar fazil-shaik fazil-shaik - edited - 20 Mar 2025
avatar fazil-shaik fazil-shaik - change - 20 Mar 2025
The description was changed
avatar fazil-shaik fazil-shaik - edited - 20 Mar 2025
avatar brianteeman
brianteeman - comment - 20 Mar 2025

Please add some screenshots to illustrate the before and after

avatar fazil-shaik fazil-shaik - change - 21 Mar 2025
The description was changed
avatar fazil-shaik fazil-shaik - edited - 21 Mar 2025
avatar fazil-shaik fazil-shaik - change - 21 Mar 2025
The description was changed
avatar fazil-shaik fazil-shaik - edited - 21 Mar 2025
avatar fazil-shaik fazil-shaik - change - 21 Mar 2025
The description was changed
avatar fazil-shaik fazil-shaik - edited - 21 Mar 2025
avatar QuyTon QuyTon - change - 27 Mar 2025
The description was changed
avatar QuyTon QuyTon - edited - 27 Mar 2025
avatar HLeithner
HLeithner - comment - 15 Apr 2025

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 15 Apr 2025
Title
#44957 fix changes added custom Trim of Ui image
[5.3] #44957 fix changes added custom Trim of Ui image
avatar HLeithner HLeithner - edited - 15 Apr 2025
avatar brianteeman
brianteeman - comment - 15 Apr 2025

I have absolutely no idea what you are trying to do here. It seems to be nothing to do with the referenced issue

avatar brianteeman
brianteeman - comment - 15 Apr 2025

Finally worked out what the changes here do and they are NOTHING to do with what you are trying to do as you are editing the wrong file completely. The file you are editing is used to display this

image

avatar brianteeman
brianteeman - comment - 15 Apr 2025

even if you were editing the correct file this is not the way to change the displayed length of a filename. The current css method is the correct way to do it. Your method can result in multiple images being displayed as the same filename etc etc

avatar QuyTon QuyTon - change - 15 Apr 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-04-15 19:12:08
Closed_By QuyTon
Labels Added: bug PR-5.3-dev
avatar QuyTon QuyTon - close - 15 Apr 2025
avatar QuyTon
QuyTon - comment - 15 Apr 2025

Closing as this is not the correct fix. Thank you for your contribution.

Add a Comment

Login with GitHub to post a comment