User tests: Successful: 0 Unsuccessful: 0
During the build process of a new release or update we remove various files that should not or do not need to be distributed
This PR extends the list of files to be removed from the libraries/vendor folder to include
.drone.yml
.drone.jsonnet
Examples can be seen in most of the libraries/vendor/joomla folders
@richard67 I assume that this will need to be added to the removed files list
Status | New | ⇒ | Pending |
Category | ⇒ | Repository |
@richard67 I assume that this will need to be added to the removed files list
@brianteeman Correct. I will handle that regularly and so add them when this PR has been merged.
@richard67 I assume that this will need to be added to the removed files list
@brianteeman Correct. I will handle that regularly and so add them when this PR has been merged.
thanks
@exlemor Testing instructions: Download the full installation zip package created by Drone for this PR, and download a recent 5.3 nightly build, and compare the content of the 2 zip files regarding files which only exist in the nightly build package but not in the one for this PR.
Package for this PR: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.3-dev/45152/downloads/83435/Joomla_5.3.0-beta3-dev+pr.45152-Development-Full_Package.zip
Nightly build: https://developer.joomla.org/nightlies/Joomla_5.3.0-beta3-dev-Development-Full_Package.zip
Result:
The comparison tool (Beyond Compare) shows the package of this PR on the left hand side and the package from the nightly build at the right hand side. It is adjusted to only show singles on the right hand side, i.e. only the files which exists on the right hand side but not at the left hand side. Other differences are not shown in this mode.
As you can see, the PR does what it claims to do.
I have tested this item ✅ successfully on da9b83f
Details about how I've tested see my previous comment.
I have tested this item ✅ successfully on da9b83f
I was able to successfully test this (thanks to @richard67's help).
I used an alternative to BeyondCompare.
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
PR-5.3-dev
|
RTC
Labels |
Added:
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-19 06:37:23 |
Closed_By | ⇒ | laoneo |
Thanks!
Thanks
Hi @brianteeman, is there perhaps a missing label for this PR, I just tried testing it and Joomla Patch Tester said:
There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation.
and the .drone.yml, .drone.jsonnet files were still present in the sub-folders..
(which led me to think, it perhaps should require a Download - Prebuilt package?)