[#45129] - [5.3] add CORS settings when install from CLI
- Ready to Commit
- Medium
- Build: 5.3-dev
- # 45129
- Diff
- alikon:patch-26
User tests: Successful: 0 Unsuccessful: 0
Pull Request for Issue # .
follow-up from #45103
Summary of Changes
added CORS settings
Testing Instructions
install joomla from cli
php installation/joomla.php
check the configuration.php
Actual result BEFORE applying this Pull Request
in the configuration.php
these values are missed
public $cors = false;
public $cors_allow_origin = '*';
public $cors_allow_headers = 'Content-Type,X-Joomla-Token';
public $cors_allow_methods = '';Expected result AFTER applying this Pull Request
these values are present
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Labels |
Added:
PR-5.3-dev
|
||
I have tested this item ✅ successfully on 6ef8574
Tested successfully.
@alikon The site is working fine after applying the PR. However, the PR description mentions checking configuration.php, but the actual changes are in ConfigurationModel. Please confirm if this is the intended behavior or if configuration.php should also reflect the changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.
@krishnaGandhi11 exaclty,
before this pr when you install joomla from CLI
those values were not written in the configuration.php file
with the pr those values are written as well
i hope i've answered your question
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.
@krishnaGandhi11 exaclty, before this pr when you install joomla from CLI those values were not written in the configuration.php file with the pr those values are written as well
i hope i've answered your question
Thank you for your response, @alikon.
I truly appreciate your time and clarification. I just wanted to ensure there is no misunderstanding—the changes in this PR are applied in ConfigurationModel.php, while the PR description mentions checking configuration.php. Could you kindly confirm if this was a miscommunication in the description? If so, updating it to reflect ConfigurationModel.php instead of configuration.php might help avoid any confusion for future reviewers and testers.
there is no misunderstanding
now i'm in doubt if you have undertood the issue and tested it correctly or simply used an AI
sorry to be blunt
The description is correct. If you don't understand it how could you mark a successful test?
| Status | Ready to Commit | ⇒ | Pending |
real human test still needed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.
there is no misunderstanding now i'm in doubt if you have undertood the issue and tested it correctly or simply used an AI sorry to be blunt
No, I was just confirming what I observed.
My-results.mp4
That video confirms you have not followed/ understood the instructions
I have removed the test result from krishnaGandhi11
so what you have observed before
and after applying the pr ?
from your video i'm still not satisfied or it's not clear to my poor "human" mind
That video confirms you have not followed/ understood the instructions
Then I really apologize, i really posted response according what i observed.
@krishnaGandhi11 you did not follow the test instructions
- Install joomla using the command line interface (cli) using the command
php installation/joomla.php - after installing joomla look in the configuration.php that is created by the installation of joomla in the ROOT of your web space
- observe that the CORS related lines are not present
- apply patch and repeat steps 1 and 2
- observe that the CORS related lines are present
@krishnaGandhi11 you did not follow the test instructions
- Install joomla using the command line interface (cli) using the command
php installation/joomla.php- after installing joomla look in the configuration.php that is created by the installation of joomla in the ROOT of your web space
- observe that the CORS related lines are not present
- apply patch and repeat steps 1 and 2
- observe that the CORS related lines are present
Thank you for the clarification, @brianteeman.
I sincerely apologize for the mistake. I now realize I misunderstood the importance of using the CLI and made an error in my testing.
I'll carefully follow the exact steps and will try to retest.
It couldn't have been more clear. Install from CLI was in the title!!
It couldn't have been more clear. Install from CLI was in the title!!
Yes I totally agree, that's my bad.
I have tested this item ✅ successfully on 6ef8574
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.
Before :
After :
I guess now i am on right path now, please lemme know.
PLEASE read more carefully
The first step is to INSTALL joomla using the CLI script
The second step is to check the values present in configuration.php in the root of your web space - NOT the values in a completely different file
What you did was just display the default help for the CLI script AND look at the values in installation/configuration.php-dist
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.
| Labels |
Added:
RTC
|
||
configuration.php
PLEASE read more carefully
The first step is to INSTALL joomla using the CLI script The second step is to check the values present in configuration.php in the root of your web space - NOT the values in a completely different file
What you did was just display the default help for the CLI script AND look at the values in installation/configuration.php-dist
Please have a look whenever you have some time(considering the PR is at RTC), and lemme know if there is still something wrong, So that I don't mess up again. Thank-you for your patience and guidance.
@krishnaGandhi11 where does it say anywhere that you should copy the file installation/configuration.php-dist to /configuration.php
Step away from the computer and come back tomorrow and then follow the instructions you have been given. Don't add something because you think it is missing, its not
I have tested this item ✅ successfully on 6ef8574Tested successfully.
@alikon The site is working fine after applying the PR. However, the PR description mentions checking configuration.php, but the actual changes are in ConfigurationModel. Please confirm if this is the intended behavior or if configuration.php should also reflect the changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.
@krishnaGandhi11 where does it say anywhere that you should copy the file installation/configuration.php-dist to /configuration.php
Step away from the computer and come back tomorrow and then follow the instructions you have been given. Don't add something because you think it is missing, its not
I see that this PR is already RTC, but I wanted to complete the testing process properly. I appreciate the comments and feedback from Mr. Brian and Mr. Alikon—thank you for your help and guidance.
PR45129.1.2.mp4
You are still NOT installing joomla from the CLI
Read The Fine Manual
https://docs.joomla.org/J4.x:Joomla_CLI_Installation
Read The Fine Manual https://docs.joomla.org/J4.x:Joomla_CLI_Installation
This manual was really helpful - please have a look!
I have tested this item ✅ successfully on 6ef8574
Settings are now written with DPDocker site installation
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.