RTC PR-5.3-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar alikon
alikon
14 Mar 2025

Pull Request for Issue # .
follow-up from #45103

Summary of Changes

added CORS settings

Testing Instructions

install joomla from cli
php installation/joomla.php
check the configuration.php

Actual result BEFORE applying this Pull Request

in the configuration.php
these values are missed

public $cors = false;
public $cors_allow_origin = '*';
public $cors_allow_headers = 'Content-Type,X-Joomla-Token';
public $cors_allow_methods = '';

Expected result AFTER applying this Pull Request

these values are present

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 14 Mar 2025
avatar alikon alikon - change - 14 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2025
Category Installation
avatar alikon alikon - change - 14 Mar 2025
Labels Added: PR-5.3-dev
avatar laoneo laoneo - test_item - 14 Mar 2025 - Tested successfully
avatar laoneo
laoneo - comment - 14 Mar 2025

I have tested this item ✅ successfully on 6ef8574

Settings are now written with DPDocker site installation


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.

avatar krishnaGandhi11 krishnaGandhi11 - test_item - 14 Mar 2025 - Tested successfully
avatar krishnaGandhi11
krishnaGandhi11 - comment - 14 Mar 2025

I have tested this item ✅ successfully on 6ef8574

Tested successfully.

@alikon The site is working fine after applying the PR. However, the PR description mentions checking configuration.php, but the actual changes are in ConfigurationModel. Please confirm if this is the intended behavior or if configuration.php should also reflect the changes.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.

avatar alikon
alikon - comment - 14 Mar 2025

@krishnaGandhi11 exaclty,
before this pr when you install joomla from CLI
those values were not written in the configuration.php file
with the pr those values are written as well

i hope i've answered your question

avatar alikon alikon - change - 14 Mar 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 14 Mar 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.

avatar krishnaGandhi11
krishnaGandhi11 - comment - 14 Mar 2025

@krishnaGandhi11 exaclty, before this pr when you install joomla from CLI those values were not written in the configuration.php file with the pr those values are written as well

i hope i've answered your question

Thank you for your response, @alikon.

I truly appreciate your time and clarification. I just wanted to ensure there is no misunderstanding—the changes in this PR are applied in ConfigurationModel.php, while the PR description mentions checking configuration.php. Could you kindly confirm if this was a miscommunication in the description? If so, updating it to reflect ConfigurationModel.php instead of configuration.php might help avoid any confusion for future reviewers and testers.

avatar alikon
alikon - comment - 14 Mar 2025

there is no misunderstanding
now i'm in doubt if you have undertood the issue and tested it correctly or simply used an AI
sorry to be blunt

avatar brianteeman
brianteeman - comment - 14 Mar 2025

The description is correct. If you don't understand it how could you mark a successful test?

avatar alikon alikon - change - 14 Mar 2025
Status Ready to Commit Pending
avatar alikon
alikon - comment - 14 Mar 2025

real human test still needed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.

avatar krishnaGandhi11
krishnaGandhi11 - comment - 14 Mar 2025

there is no misunderstanding now i'm in doubt if you have undertood the issue and tested it correctly or simply used an AI sorry to be blunt

No, I was just confirming what I observed.

My-results.mp4
avatar brianteeman
brianteeman - comment - 14 Mar 2025

That video confirms you have not followed/ understood the instructions

avatar brianteeman brianteeman - alter_testresult - 14 Mar 2025 - krishnaGandhi11: Not tested
avatar brianteeman
brianteeman - comment - 14 Mar 2025

I have removed the test result from krishnaGandhi11

avatar alikon
alikon - comment - 14 Mar 2025

so what you have observed before
and after applying the pr ?
from your video i'm still not satisfied or it's not clear to my poor "human" mind

avatar krishnaGandhi11
krishnaGandhi11 - comment - 14 Mar 2025

That video confirms you have not followed/ understood the instructions

Then I really apologize, i really posted response according what i observed.

avatar brianteeman
brianteeman - comment - 14 Mar 2025

@krishnaGandhi11 you did not follow the test instructions

  1. Install joomla using the command line interface (cli) using the command php installation/joomla.php
  2. after installing joomla look in the configuration.php that is created by the installation of joomla in the ROOT of your web space
  3. observe that the CORS related lines are not present
  4. apply patch and repeat steps 1 and 2
  5. observe that the CORS related lines are present
avatar krishnaGandhi11
krishnaGandhi11 - comment - 14 Mar 2025

@krishnaGandhi11 you did not follow the test instructions

  1. Install joomla using the command line interface (cli) using the command php installation/joomla.php
  2. after installing joomla look in the configuration.php that is created by the installation of joomla in the ROOT of your web space
  3. observe that the CORS related lines are not present
  4. apply patch and repeat steps 1 and 2
  5. observe that the CORS related lines are present

Thank you for the clarification, @brianteeman.

I sincerely apologize for the mistake. I now realize I misunderstood the importance of using the CLI and made an error in my testing.

I'll carefully follow the exact steps and will try to retest.

avatar brianteeman
brianteeman - comment - 14 Mar 2025

It couldn't have been more clear. Install from CLI was in the title!!

avatar krishnaGandhi11
krishnaGandhi11 - comment - 14 Mar 2025

It couldn't have been more clear. Install from CLI was in the title!!

Yes I totally agree, that's my bad.

avatar brianteeman brianteeman - test_item - 14 Mar 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Mar 2025

I have tested this item ✅ successfully on 6ef8574


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.

avatar krishnaGandhi11
krishnaGandhi11 - comment - 14 Mar 2025

Before :
image


After :
image

I guess now i am on right path now, please lemme know.

avatar brianteeman
brianteeman - comment - 14 Mar 2025

PLEASE read more carefully

The first step is to INSTALL joomla using the CLI script
The second step is to check the values present in configuration.php in the root of your web space - NOT the values in a completely different file

What you did was just display the default help for the CLI script AND look at the values in installation/configuration.php-dist

avatar QuyTon QuyTon - change - 14 Mar 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 14 Mar 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.

avatar QuyTon QuyTon - change - 14 Mar 2025
Labels Added: RTC
avatar krishnaGandhi11
krishnaGandhi11 - comment - 14 Mar 2025

configuration.php

PLEASE read more carefully

The first step is to INSTALL joomla using the CLI script The second step is to check the values present in configuration.php in the root of your web space - NOT the values in a completely different file

What you did was just display the default help for the CLI script AND look at the values in installation/configuration.php-dist

Please have a look whenever you have some time(considering the PR is at RTC), and lemme know if there is still something wrong, So that I don't mess up again. Thank-you for your patience and guidance.
image

avatar brianteeman
brianteeman - comment - 14 Mar 2025

@krishnaGandhi11 where does it say anywhere that you should copy the file installation/configuration.php-dist to /configuration.php

Step away from the computer and come back tomorrow and then follow the instructions you have been given. Don't add something because you think it is missing, its not

avatar krishnaGandhi11
krishnaGandhi11 - comment - 15 Mar 2025

I have tested this item ✅ successfully on 6ef8574Tested successfully.

@alikon The site is working fine after applying the PR. However, the PR description mentions checking configuration.php, but the actual changes are in ConfigurationModel. Please confirm if this is the intended behavior or if configuration.php should also reflect the changes.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45129.

@krishnaGandhi11 where does it say anywhere that you should copy the file installation/configuration.php-dist to /configuration.php

Step away from the computer and come back tomorrow and then follow the instructions you have been given. Don't add something because you think it is missing, its not

I see that this PR is already RTC, but I wanted to complete the testing process properly. I appreciate the comments and feedback from Mr. Brian and Mr. Alikon—thank you for your help and guidance.

PR45129.1.2.mp4
avatar brianteeman
brianteeman - comment - 15 Mar 2025

You are still NOT installing joomla from the CLI

avatar brianteeman
brianteeman - comment - 15 Mar 2025

Add a Comment

Login with GitHub to post a comment