[#45118] - [5.3]Fixed manual Unblock sets user as Activated (Verified) issue
- Pending
- Medium
- Build: 5.3-dev
- # 45118
- Diff
- Amitesh007z:fix-admin-unblock-activation
User tests: Successful: 0 Unsuccessful: 0
Pull Request for Issue #45063 .
Summary of Changes:
This PR fixes an issue where manually unblocking a user does not set them as Activated (Verified). Previously, when an admin unblocked a user, the activation state remained unchanged, which could cause login issues. This fix ensures that when an admin unblocks a user, their activation status is also updated to Verified.
Testing Instructions
Testing Instructions
Log in to the Joomla administrator panel.
Navigate to Users → Manage Users.
Now new create account ,
traverse back to manage users panel and check unblocking (it must eventually activate respective user which happens when the same user verifies mail and admin verifies mail)
Actual result BEFORE applying this Pull Request
above image is result of manual unblock by admin where activation is red
above image is result of other method i.e through mail verification of user and admin .
Expected result AFTER applying this Pull Request
on manual click on unblock (i.e manually unblocking), gives green to activation too, which results in consistency.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
| Labels |
Added:
PR-5.3-dev
|
||
Your assumptions are wrong.
If the site is set to no verfication then the user is marked as activated on registration
As stated before - until all the possible registration scenarios are documented it is not a good idea to change anything here
Hi @brianteeman sir,
I’ve made the changes to address the inconsistency as instructed by MacJoom while ensuring the registration process remains unaffected sir . I really appreciate your guidance on this sir . Please let me know if there’s anything I might have missed or if further adjustments are needed sir . Happy to make any necessary changes
@richard67
i would be happy to hear further review and feedback sir , also further steps to be done sir
The Summary of Changes looks very structured and clear. Compliments and many thanks for this. Not all PRs are so well documented, which makes it often difficult for testers to get the perspective.
I am the person who originally reported this issue. But I am afraid, my request was somewhat misunderstood. My concern is NOT about the manual addition of users by the administrator. I wanted to discuss whether the user registration process should be improved in case the option ‘New User Account Activation’ is set to ’Administrator’.
IS
- A user registers for a new account
- He clicks the verification link in the email he receives
- This action does not change the state of the two icons, neither «Enabled» nor «Activated». Literally speaking this is correct, since the user only has verified his email address, but not activated his account. Keep in mind that the option ‘New User Account Activation’ is set to ’Administrator’.
MY PROPOSAL
- A user registers for a new account
- He clicks the verification link in the email he receives
- This action should change the state of the second of these icons. This allows the administrator to determine that the account has been verified. Otherwise he would have to guess the verification status from the fact, that he has received a notification email from the new user account.
- My proposal would make it necessary that the column's heading is renamed from «Activated» to «Verified».
Summarising I would think, that my propsal would make the whole user registration and approval process more transparent and clear then it was until now.
BY NO MEANS is it necessary, to completely rewrite this function from the scratch. It basically works, but could be clarified a little bit.
Your assumptions are wrong.
If the site is set to no verfication then the user is marked as activated on registration
As stated before - until all the possible registration scenarios are documented it is not a good idea to change anything here