User tests: Successful: 2 exlemor, krishnaGandhi11 Unsuccessful: 0
Pull Request for Issue # .
While doing code review for PR #44885, I noticed some bad code in CategoryeditField class. This PR improves code of that class, make code cleaner and easier to read:
isset($this->element['extension'])
to check if the extension attribute is defined for the field. It's more cleaner than just use $this->element['extension'] in the if condition check. Similar for other code which is used to check for existence of an attribute in the field.Works
Works, with cleaner code, and slight faster.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_categories |
Labels |
Added:
PR-5.3-dev
|
I will say I didn't get a sense of speed improvement
The speed improvement is in theory only, for small change like this, it is not noticeable.
I just noticed an error in the code and fix it. Could you please help testing it again when you have time? Sorry for the inconvenience and thanks for testing @exlemor
I have tested this item ✅ successfully on c57f918
Test successful: the Parent field and Category field behave the same as before.
Thanks! @joomdonation.
I have tested this item ✅ successfully on c57f918
I have re-tested this just now successfully. :)
Thanks, @joomdonation
Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks for testing @krishnaGandhi11 and @exlemor
I have tested this item ✅ successfully on b646306
I have tested this successfully. I will say I didn't get a sense of speed improvement but then again I was on a simple structured test website, probably more visible on a large website. Thanks @joomdonation!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45116.