Pull Request for Issue # .

Summary of Changes

While doing code review for PR #44885, I noticed some bad code in CategoryeditField class. This PR improves code of that class, make code cleaner and easier to read:

• Introduce local variable $isParentCategoryField instead of repeating call code $this->element['parent'] || $jinput->get('option') == 'com_categories' everywhere when we need to check if this field is used to allow choosing parent categories.
• Use isset($this->element['extension']) to check if the extension attribute is defined for the field. It's more cleaner than just use $this->element['extension'] in the if condition check. Similar for other code which is used to check for existence of an attribute in the field.

Testing Instructions

• Use Joomla 5.3
• Edit a category, and look at categories displayed in Parent field. Make sure it is the same before and after applying changes from this PR.
• Edit an article, and look at categories displayed in Category field. Make sure it is the same before and after applying changes from this PR.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner code, and slight faster.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed