Language Change PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Amitesh007z
Amitesh007z
11 Mar 2025

Pull Request for Issue #45063 .

Summary of Changes

Done as per requeest on last PR ,upon discussion with issue author in last PR now it shows green tick whenever usser verifies email, under activated in admin.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Amitesh007z Amitesh007z - open - 11 Mar 2025
avatar Amitesh007z Amitesh007z - change - 11 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2025
Category Administration com_users Installation Language & Strings
avatar richard67
richard67 - comment - 11 Mar 2025

@Amitesh007z Please check the list of changed files for your PR on GitHub here: https://github.com/joomla/joomla-cms/pull/45111/files

It shows 198 changed files, also lots of deleted files.

And lots of wrong code style changes which could be related to wrong editor settings in an IDE.

And you should not use unicode characters like green check marks in comments in PHP files.

avatar richard67
richard67 - comment - 11 Mar 2025

P.S.: Your PR deletes the complete installation folder. It seems you have just checked in your branch after having made a Joomla installation, which included deleting that folder.

avatar Amitesh007z
Amitesh007z - comment - 11 Mar 2025

P.S.: Your PR deletes the complete installation folder. It seems you have just checked in your branch after having made a Joomla installation, which included deleting that folder.

hi @richard67 , i have made some changes in logic which would lead to showing green tick whenever mail verification happens, i dont know whats happening , i just made changes and pushed it to 5.3 dev branch as its the origin for the isssue , anyways i will look through once and make sure the PR is fine and working as per expected, coming to installation , i felt like i already made necessary installation in my system locally , so i deleted , now im understanding the issue slowly , will sort it out and come with proper PR ,
sorry for inconvenience sir

avatar fgsw
fgsw - comment - 12 Mar 2025

@Amitesh007z Can you please append to the title "[5.3] " as in other pull requests and make clear, what is changed instead of "Fix"?

It's easier for tester and the title is used in the changelog.

avatar Amitesh007z Amitesh007z - change - 12 Mar 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-03-12 07:03:08
Closed_By Amitesh007z
Labels Added: Language Change PR-5.3-dev
avatar Amitesh007z Amitesh007z - close - 12 Mar 2025

Add a Comment

Login with GitHub to post a comment