RTC bug PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Dileepadari
Dileepadari
10 Mar 2025

Pull Request for Issue #37841

Summary of Changes

The default label for the articles filter in the user login has been updated to align with the actual default option (ID Descending). Previously, the label was incorrectly set to TITLE Ascending, while the functionality still followed ID Descending. This fix ensures that the label correctly reflects the selected sorting order.

Testing Instructions

  1. Navigate to: your.domain/index.php?option=com_content&view=form&layout=edit
  2. Select Article as the Menu Item Type (default is CMS content).
  3. A modal window with articles will open.
  4. Check the default filter dropdown—it should now correctly display ID Descending as both the label and the actual sorting option.

Actual result BEFORE applying this Pull Request

  • The default filter label was incorrectly set to TITLE Ascending, while the actual sorting used ID Descending.
    before

Expected result AFTER applying this Pull Request

  • Both the label and the selected option now correctly show ID Descending (ensuring that the latest articles appear first).
    after

Link to Documentation

  • Documentation link for docs.joomla.org: <link>

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: <link>

  • No documentation changes for manual.joomla.org needed

avatar Dileepadari Dileepadari - open - 10 Mar 2025
avatar Dileepadari Dileepadari - change - 10 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2025
Category Front End com_content
avatar Dileepadari Dileepadari - change - 10 Mar 2025
Title
cleared miss match between default option and label in articles filter
[5.2] cleared miss match between default option and label in articles filter
avatar Dileepadari Dileepadari - edited - 10 Mar 2025
avatar Dileepadari Dileepadari - change - 10 Mar 2025
The description was changed
avatar Dileepadari Dileepadari - edited - 10 Mar 2025
avatar Dileepadari Dileepadari - change - 10 Mar 2025
The description was changed
avatar Dileepadari Dileepadari - edited - 10 Mar 2025
avatar richard67
richard67 - comment - 12 Mar 2025

@Dileepadari If you check the changed files of this PR on GitHub here, you will see that you also changed the file permissions from 644 to 755. Could you revert that?
2025-03-12_pr-45106_unwanted-mode-change

avatar Dileepadari Dileepadari - change - 13 Mar 2025
Labels Added: PR-5.2-dev
avatar Dileepadari
Dileepadari - comment - 13 Mar 2025

Thanks for pointing it out, I changed the permissions back to 644. Also please let me know should I use the same pr to clear the other two issues too or can we merge this?

avatar QuyTon QuyTon - test_item - 15 Mar 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 15 Mar 2025

I have tested this item ✅ successfully on 37cf38b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45106.

avatar fgsw
fgsw - comment - 15 Mar 2025

@Dileepadari

as far as i know:

Merging a branch in your Pull Request invalidate test result (you see the result of @QuyTon is gone in the checks).

Better to wait for a second successfully test and set to "Ready to Commit" (RTC) by a maintainer. After setting RTC merging the branch doesn't harm test results.

avatar Dileepadari
Dileepadari - comment - 15 Mar 2025

@fgsw Thank you for informing me about this. I’ll wait for the next test. I initially thought the PR needed to be rebased to stay updated, but now I understand the process better. I’ll keep that in mind going forward.

avatar fgsw fgsw - test_item - 15 Mar 2025 - Tested successfully
avatar fgsw
fgsw - comment - 15 Mar 2025

I have tested this item ✅ successfully on 1bf3379

Test by using custom update server of prebuilt packages.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45106.

avatar QuyTon QuyTon - change - 15 Mar 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 15 Mar 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45106.

avatar QuyTon QuyTon - alter_testresult - 16 Mar 2025 - QuyTon: Tested successfully
avatar QuyTon QuyTon - change - 16 Mar 2025
Labels Added: RTC
avatar HLeithner
HLeithner - comment - 15 Apr 2025

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - edited - 15 Apr 2025
avatar HLeithner HLeithner - change - 15 Apr 2025
Title
[5.2] cleared miss match between default option and label in articles filter
[5.3] cleared miss match between default option and label in articles filter
avatar richard67 richard67 - change - 20 Apr 2025
Labels Added: bug PR-5.3-dev
Removed: PR-5.2-dev
avatar richard67 richard67 - change - 20 Apr 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-04-20 11:32:36
Closed_By richard67
avatar richard67 richard67 - close - 20 Apr 2025
avatar richard67 richard67 - merge - 20 Apr 2025
avatar richard67
richard67 - comment - 20 Apr 2025

@Dileepadari Thank you very much and congratulations for your first merged pull request. We are always happy to see new contributors.

And thanks to testers.

Add a Comment

Login with GitHub to post a comment