[#45099] - [5.2] fix orphan components through trash
- Pending
- Medium
- Build: 5.2-dev
- # 45099
- Diff
- reem-atalah:orphan-components
User tests: Successful: 0 Unsuccessful: 0
Pull Request for Issue #45026.
Summary of Changes
Add a new button called Trash in the Actions dropdown list on the Users page when selecting a user and clicking on it, the user is soft deleted.
Testing Instructions
Go to Users -> Create New User
(
Go to Articles -> Create New Article
Go to the Publishing tab -> Set the Created By to the new user
Go to Users -> Select the new user -> Click on Actions dropdown list -> Click on Trash
or
Login with the new user
Go to Articles -> Create New Article
Logout and login again with an administrator user
Go to Users -> Select the new user -> Click on Actions dropdown list -> Click on Trash
)
Go to the article where the Create By is the deleted user, edit and save it, it will be saved normally.
Actual result BEFORE applying this Pull Request
Deleting a user from the system will mean you have 'orphan' articles, categories, and other items within Joomla, so you can no longer edit those records, unless the create by is changed.
Expected result AFTER applying this Pull Request
Deleting a user from the system using the Trash button will soft delete the user where the user won't appear in the users' list, and we can't log in with that user. However we can edit contents created by this user.
Note: the Delete button still exists.
freecompress-joomla.trash.user.mp4
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Language & Strings |
| Labels |
Added:
Language Change
PR-5.2-dev
|
||
Thank you for working on that problem.
It is an interesting approach but
- This is a feature, please make the PR for the 6.0 branch (the simple way is to close this PR and start new).
- Describe your intention in the form (Summary of Changes)
- Write good test instructions, so that people know how they can test.
- This is a new behaviour and - if accepted - needs decumentation.
Then maintainers and users will say their opinion.
I can already tell you, that users are not trashable. Besides the outwards appearance that people are never trash, the whole concept of trashing an item does not apply to users.
| Labels |
Added:
Feature
|
||
| Category | Administration com_users Language & Strings | ⇒ | Administration com_users Language & Strings Libraries |
Users cannot be "trashed" but I think it is a good attempt to keep the id and anonymise data.
Then these records do not represent users - they cannot login and do not have any rights.
Ok then I can make a soft delete as a first step, and then we can filter on "Deleted" users, so we can delete them again permanently, or just have a soft delete?
I'd say first step is anonymising data and adding a filter (my personal opinion / expectation)
But be aware that this is one of these PRs where you get 10 answers if you ask 5 people. I see it as a valuable proof of concept, where many questions and many expectations remain unsanswered
| Title |
|
||||||
Hello all,
I have read the history links attached to the issue.
I can see that the last update is this comment, my POC is to trash/archive a user instead of deleting, i.e. similar to putting articles in the trash, I need to put the user in the trash, the user in the trash should have no privileges at all ( act as deleted, but the user's record exists), then when the user enters the trash, he can delete the user, but give him a warning that this can cause side effects.
But I'm confused somehow of how to implement this, as it's a new feature rather than updating an existing one.
Appreciate your guidance.