[#45096] - [5.2] Calendar: Highlight selected day in frontend
- Closed
- 11 Mar 2025
- Medium
- Build: 5.2-dev
- # 45096
- Diff
- krishnaGandhi11:feature
User tests: Successful: Unsuccessful:
Pull Request for Issue #45082
Summary of Changes :
-Fixed the issue where the selected day in the calendar was not highlighted in the frontend.
-Applied correct styling to match the backend calendar appearance.
Testing Instructions :
-Open an article and try to set a publishing date (this opens the calendar).
-Select a date and check if it gets highlighted properly.
-Test on multiple browsers (Chrome, Firefox, Edge, Safari).
Actual result BEFORE applying this Pull Request :
-The selected date in the calendar was not highlighted in the frontend.
-The backend calendar worked correctly, but the frontend did not.
Expected result AFTER applying this Pull Request :
-The selected date should now be properly highlighted in the frontend calendar, just like in the backend.
Fixed.mp4
Fixes #45082
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
Sorry, but this is wrong. We cannot use hard coded colours. My screen shows clearly that there is a bootstap variable missing.
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
| Category | Repository NPM Change | ⇒ | Repository NPM Change Front End Templates (site) |
Sorry this is completely wrong.
The problem is that the css for the calendar field is using a bootstrap variable that is for some reason not present in the cassiopeia template.
The correct fix is not to hard code colours (both your approaches are hard coding colours) but to understand why some of the bootstrap variables are not present in the cassiopeia template and then to fix the cassiopeia template so that those variables are present.
There should be no need to even touch the css file for the calendar field
| Category | Repository NPM Change Front End Templates (site) | ⇒ | Repository NPM Change Front End Templates (site) Unit Tests |
Changes Made:
Defined missing Bootstrap variables in :root {} inside templates/cassiopeia/index.php to ensure proper styling of buttons:
--btn-primary-bg: #007bdb;
--btn-primary-color: #ffffff;
--btn-primary-border: #00a1e3;
Ensured that bootstrap.loadCss is included in the Cassiopeia template to properly load Bootstrap styles.
Fixed a typo in tests/System/README.md for consistency.
One topic per pull request please. Your changes to the tests readme are unrelated to the subject of this pr
Why are you loading bootstrap CSS twice. The Cassiopeia template is already using bootstrap.
| Labels |
Added:
Unit/System Tests
|
||
Why are you loading bootstrap CSS twice. The Cassiopeia template is already using bootstrap.
Yeah sorry about that, as i have to first pull before pushing in that process, it happened by mistake.
Hey @brianteeman I have removed the Double boot-strap loading issue, please look into this now.
sorry but this is completely wrong - you are now loading bootstrap three times.
Maybe someone else can help you on this as I am clearly failing to make myself understood
sorry but this is completely wrong - you are now loading bootstrap three times.
Maybe someone else can help you on this as I am clearly failing to make myself understood
https://github.com/user-attachments/assets/39bdd6ab-7bc3-48b4-a622-0270c501fbe6
I am sorry, @brianteeman now it's fine ?
no. Stop and think. Is the cassiopeia template already using bootstrap. The answer is yes. So if the answer is yes you dont need to additionally load bootstrap!!
Sorry but this is my last comment - if I have to walk you through every step then I might as well fix it myself - maybe someone else can help you
no. Stop and think. Is the Cassiopeia template already using bootstrap? The answer is yes. So if yes, you don't need to load bootstrap additionally!!
Sorry but this is my last comment - if I have to walk you through every step then I might as well fix it myself - maybe someone else can help you
I am sorry now I know that every bootstrap loading I was trying to do was unnecessary, now in the last PR Update I have fixed that.
I have tested this item ✅ successfully on e20d16e
I have tested this successfully.
Hoping the coding part meets the standards - from a visual perspective it is corrected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45096.
@krishnaGandhi11 Can you please change the title, as it is used for the changelog. Hav a look to other pull requests so it should be something like "[5.2] Calendar: Highlight selected day in frontend". The issue-number isn't needed.
| Title |
|
||||||
@krishnaGandhi11 Can you please change the title, as it is used for the changelog. Hav a look to other pull requests so it should be something like "[5.2] Calendar: Highlight selected day in frontend". The issue-number isn't needed.
Sure, it’s done.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-11 18:32:57 |
| Closed_By | ⇒ | krishnaGandhi11 |
I have tested this item ✅ successfully on 052f224
I have tested this successfully via Download package. Good job Krishna.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45096.