Feature UI/UX PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
5 Mar 2025

Pull Request for Issue #44118 .
Replaces #44246 due to conflicts after rebasing

Summary of Changes

This PR re-arranges fields and tabs in frontend edit for articles.
It moves all options which are in the right sidbar of articles to a new tab "options"
It writes all fields which are in the publishing tab of the article into the publishing tab.
This removes the language tab and the metadata tab.

Testing Instructions

Compare the edit form for an article before and after the PR. Make sure that different user groups witrh different permissions have the same fields before and after the pr.
Switch on and off the show_publishing_data in articles options. on: publishing tab exists, off: no publishing data.
Check multilingual sites, if languages and associations are correct.

Actual result BEFORE applying this Pull Request

see #44118

Expected result AFTER applying this Pull Request

grafik
grafik

REMARK
It would be correct to have a new param for switching on and off the publishing tab.
Could be a follow-up PR.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar chmst chmst - open - 5 Mar 2025
avatar chmst chmst - change - 5 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2025
Category Front End com_content
avatar chmst chmst - change - 6 Mar 2025
Labels Added: Feature UI/UX PR-6.0-dev
avatar chmst chmst - change - 7 Mar 2025
The description was changed
avatar chmst chmst - edited - 7 Mar 2025
avatar exlemor exlemor - test_item - 9 Mar 2025 - Tested successfully
avatar exlemor
exlemor - comment - 9 Mar 2025

I have tested this item ✅ successfully on 130af2a

Hi @chmst, I have tested this successfully.

Tried it on a non multi-lingual site, turning on/off options in the Articles Options, then installed Multi-Lingual Sample Data, and did the same... turned on/off workflows and many other settings in Articles and all good/correct from a perspective of your PR...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45081.
avatar exlemor
exlemor - comment - 9 Mar 2025

That said, (and this may be need to be done outside of this PR), I did find something odd but it has nothing to do with your PR because the behaviour appears with your PR is turned off/unpatched.

Workflow Turned OFF:
With-Workflow-turned-OFF

Workflow Turned ON:
With-Workflow-turned-ON

avatar fgsw
fgsw - comment - 9 Mar 2025

@exlemor Same as in backend:

Untitled

avatar exlemor
exlemor - comment - 9 Mar 2025

@fgsw - sure (thanks), but why is that? i.e. all of the other fields look the same, are selectable etc except these - even if it is because they shouldn't be selectable it's odd visually no?

avatar Bodge-IT Bodge-IT - test_item - 9 Mar 2025 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 9 Mar 2025

I have tested this item ✅ successfully on 130af2a

Clean test, although metadata not as imaged but wrapped in context box. Not an aspect of the PR tho.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45081.

avatar brianteeman
brianteeman - comment - 9 Mar 2025

@Bodge-IT if your test does not match the expected result in the pull request it can not be a successful test - unless @chmst says that their images are wrong

avatar Bodge-IT
Bodge-IT - comment - 9 Mar 2025

@Bodge-IT if your test does not match the expected result in the pull request it can not be a successful test - unless @chmst says that their images are wrong

image
My test showed "Metadata" wrapper but this PR originally from 5.2 and does not affect nature of the PR.

avatar brianteeman
brianteeman - comment - 9 Mar 2025

what is the point in anyone testing anything if test results that are different to those expected are marked as successful

avatar Bodge-IT
Bodge-IT - comment - 9 Mar 2025

Hi @chmst , can you please update your result images to include the rendered < fieldset> and < legend> markup added by your code? or remove those tags to stay consistent with current images.

Add a Comment

Login with GitHub to post a comment