[#45077] - [5.3] Clean up com_templates StyleModel
- Fixed in Code Base
- 9 Mar 2025
- Medium
- Build: 5.3-dev
- # 45077
- Diff
- joomdonation:com_templates_style_model
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR makes several clean up to com_templates StyleModel:
- Remove
populateStatemethod, it does not do anything different than the code in parent class, so the override is useless - Improve
getItemmethod. Instead of copying code from parent class, we just call the method from parent class to get item data, then add additional logic to it. - Improve
preprocessFormcode, prevent potential warnings when saving item failure (in that case, $data is an array, so we could not treat it as an object like how we do in the code at the moment)
Testing Instructions
- Use Joomla 5.3
- Apply patch
- Access to System -> Template Styles, edit a template style and make sure it is still working as expected
Actual result BEFORE applying this Pull Request
Works, but there is potential warning when saving item false (not easy to show it to you)
Expected result AFTER applying this Pull Request
Works, with less, cleaner code and no potential warnings.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
| Labels |
Added:
PR-5.3-dev
|
||
I have tested on fc4338fbe3 with only the System Tests. Before applying this PR there are PHP Warnings:
api/com_templates/Site.cy.js
PHP Warning: Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 399
PHP Warning: Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 400
PHP Warning: Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 399
PHP Warning: Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 400
- and
api/com_templates/Administrator.cy.js
PHP Warning: Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 399
PHP Warning: Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 400
✅ After applying this PR the two tests are passing successfully and without PHP warnings.
@joomdonation Is it enough to modify a template style and save? Or mean the instructions another way saying "potential warning when saving item false (not easy to show it) (…) Works (…) no potential warnings".
I have tested this item ✅ successfully on 043c7ad
Changed all colour fields settings, added an image to each image field.
- Result: Same behaviour as without pull request.
- Test by using custom update server.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45077.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks for testing!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45077.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-09 07:58:56 |
| Closed_By | ⇒ | laoneo |
Thanks!
Thanks everyone !
I have tested this item ✅ successfully on 24d923d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45077.