User tests: Successful: Unsuccessful:
Updates the dependencies.
Status | New | ⇒ | Pending |
Category | ⇒ | External Library Composer Change NPM Change |
Title |
|
Labels |
Added:
Composer Dependency Changed
NPM Resource Changed
PR-5.3-dev
|
@laoneo Could you update this PR for the new version 3.1.0 of the filesystem framework? https://github.com/joomla-framework/filesystem/releases/tag/3.1.0
done
Thanks. That was quick.
I have tested this item ✅ successfully on caa3c70
I've reviewed the changes and have compared the full install zip packages created without and with this PR, have compared the console output from both builds, and have tested an installation with the PR applied and finally a live update of that installation to the patched package for this PR.
It all worked, and the comparison of the packages has not shown any unexpected differences, i.e. our js and css compile works as before.
On the installation with the PR applied, there were no unexpected new errors in the PHP error log or the developer console.
It is then already up to date.
That still doesn’t explain why you don’t restore the human test with the „alter test“ button in the issue tracker after the branch update.
Status | Pending | ⇒ | Ready to Commit |
rtc
rtc
Not really right as @brianteeman ‘s test was invalidated by a later commit which updated again some dependencies.
Status | Ready to Commit | ⇒ | Pending |
back to pending then
back to pending then
It still needs to restore my test result in the issue tracker so that my test is still counted because the commit after my test was just a clean branch update. I will do that for now, but plese remember doing that yourself next time when you update the branch of a PR which has tests but is not RTC yet so you don't cause additional work for other maintainers. Thanks.
Thanks
@brianteeman Could you repeat your test (or review)? The PR has received an update meanwhile. Thanks in advance.
esbuild <=0.24.2
Severity: moderate
esbuild enables any website to send any requests to the development server and read the response - GHSA-67mh-4wv8-2f99
fix available via npm audit fix --force
Will install esbuild@0.25.1, which is a breaking change
Well, it requires the force parameter and is a breaking change, so we can’t do that, I think.
And it is on development only anyway, not being shipped with the public installable package.
In the last commit are only dev dependencies updated.
Can you guys give this one here another test, so we will be then one step closer to drone PHP 8.4 compatibility.
I have tested this item ✅ successfully on a76b798
tests ok for me
Shouldnt this be updated as well. Because its a 0.x version the normal semver calculations dont hold true
joomla-ui-custom-elements 0.2.0 0.2.0 0.4.1 node_modules/joomla-ui-custom-elements
I have tested this item ✅ successfully on 2d6b088
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071.