Composer Dependency Changed NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
5 Mar 2025

Updates the dependencies.

avatar laoneo laoneo - open - 5 Mar 2025
avatar laoneo laoneo - change - 5 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2025
Category External Library Composer Change NPM Change
avatar laoneo laoneo - change - 5 Mar 2025
Title
Update dependencies
[5.3] Update dependencies
avatar laoneo laoneo - edited - 5 Mar 2025
avatar laoneo laoneo - change - 5 Mar 2025
Labels Added: Composer Dependency Changed NPM Resource Changed PR-5.3-dev
avatar brianteeman brianteeman - test_item - 5 Mar 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Mar 2025

I have tested this item ✅ successfully on 2d6b088


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071.

avatar richard67
richard67 - comment - 7 Mar 2025

@laoneo Could you update this PR for the new version 3.1.0 of the filesystem framework? https://github.com/joomla-framework/filesystem/releases/tag/3.1.0

avatar laoneo
laoneo - comment - 7 Mar 2025

done

avatar richard67
richard67 - comment - 7 Mar 2025

Thanks. That was quick.

avatar richard67 richard67 - test_item - 7 Mar 2025 - Tested successfully
avatar richard67
richard67 - comment - 7 Mar 2025

I have tested this item ✅ successfully on caa3c70

I've reviewed the changes and have compared the full install zip packages created without and with this PR, have compared the console output from both builds, and have tested an installation with the PR applied and finally a live update of that installation to the patched package for this PR.

It all worked, and the comparison of the packages has not shown any unexpected differences, i.e. our js and css compile works as before.

On the installation with the PR applied, there were no unexpected new errors in the PHP error log or the developer console.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071.
avatar richard67
richard67 - comment - 8 Mar 2025

@laoneo Why have you invalidated the human test count by an unnecessary branch update?

avatar laoneo
laoneo - comment - 9 Mar 2025

It is then already up to date.

avatar richard67
richard67 - comment - 9 Mar 2025

That still doesn’t explain why you don’t restore the human test with the „alter test“ button in the issue tracker after the branch update.

avatar laoneo laoneo - change - 9 Mar 2025
Status Pending Ready to Commit
avatar laoneo
laoneo - comment - 9 Mar 2025

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071.

avatar richard67
richard67 - comment - 9 Mar 2025

rtc

Not really right as @brianteeman ‘s test was invalidated by a later commit which updated again some dependencies.

avatar laoneo laoneo - change - 9 Mar 2025
Status Ready to Commit Pending
avatar laoneo
laoneo - comment - 9 Mar 2025

back to pending then


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071.

avatar richard67
richard67 - comment - 9 Mar 2025

back to pending then

It still needs to restore my test result in the issue tracker so that my test is still counted because the commit after my test was just a clean branch update. I will do that for now, but plese remember doing that yourself next time when you update the branch of a PR which has tests but is not RTC yet so you don't cause additional work for other maintainers. Thanks.

avatar richard67 richard67 - alter_testresult - 9 Mar 2025 - richard67: Tested successfully
avatar laoneo
laoneo - comment - 9 Mar 2025

Thanks

avatar richard67
richard67 - comment - 9 Mar 2025

@brianteeman Could you repeat your test (or review)? The PR has received an update meanwhile. Thanks in advance.

avatar brianteeman
brianteeman - comment - 10 Mar 2025

esbuild <=0.24.2
Severity: moderate
esbuild enables any website to send any requests to the development server and read the response - GHSA-67mh-4wv8-2f99
fix available via npm audit fix --force
Will install esbuild@0.25.1, which is a breaking change

avatar richard67
richard67 - comment - 10 Mar 2025

Well, it requires the force parameter and is a breaking change, so we can’t do that, I think.

avatar laoneo
laoneo - comment - 10 Mar 2025

And it is on development only anyway, not being shipped with the public installable package.

avatar laoneo
laoneo - comment - 13 Mar 2025

In the last commit are only dev dependencies updated.

avatar laoneo
laoneo - comment - 13 Mar 2025

Can you guys give this one here another test, so we will be then one step closer to drone PHP 8.4 compatibility.

avatar brianteeman brianteeman - test_item - 13 Mar 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 13 Mar 2025

I have tested this item ✅ successfully on a76b798

tests ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071.

avatar brianteeman
brianteeman - comment - 13 Mar 2025

Shouldnt this be updated as well. Because its a 0.x version the normal semver calculations dont hold true

joomla-ui-custom-elements 0.2.0 0.2.0 0.4.1 node_modules/joomla-ui-custom-elements

Add a Comment

Login with GitHub to post a comment