[#45045] - [5.3] Remove un-used variables
- Fixed in Code Base
- 8 Mar 2025
- Medium
- Build: 5.3-dev
- # 45045
- Diff
- joomdonation:remove_unused_variables
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This simple PR remove the un-used variables in several methods across our code base. The rector rule RemoveUnusedVariableAssignRector help detects these variables. There are more un-used variables, but I only remove the most obvious one.
Testing Instructions
Code review. With a modern IDE like PHPStorm, you can easily check and see these variables are not used at all in the method it is defined/assigned value.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config com_messages com_templates com_users |
I have tested this item ✅ successfully on 318ceb5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45045.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45045.
| Labels |
Added:
RTC
PR-5.3-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-08 18:51:56 |
| Closed_By | ⇒ | rdeutz |
I have tested this item ✅ successfully on 318ceb5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45045.