RTC Webservices PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
1 Mar 2025

Pull Request for Issue #44947 .

Summary of Changes

define $modified_by

Testing Instructions

Do an API GETcall to

  • /api/index.php/v1/newsfeeds/feeds
  • /api/index.php/v1/contacts

See PHP error log.

Actual result BEFORE applying this Pull Request

Undefined property: stdClass::$modified_by in \api\components\com_newsfeeds\src\Serializer\NewsfeedSerializer.php on line 110
Undefined property: stdClass::$modified_by in \api\components\com_newsfeeds\src\Serializer\NewsfeedSerializer.php on line 111
Undefined property: stdClass::$modified_by in \api\components\com_contact\src\Serializer\ContactSerializer.php on line 110
Undefined property: stdClass::$modified_by in \api\components\com_contact\src\Serializer\ContactSerializer.php on line 111

Expected result AFTER applying this Pull Request

no more

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 1 Mar 2025
avatar alikon alikon - change - 1 Mar 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Mar 2025
Category Administration com_contact com_newsfeeds
avatar muhme
muhme - comment - 1 Mar 2025

✅ successful tested with JBT, before applying this PR

scripts/create 53
scripts/test 53 system api/com_newsfeed/NewsFeed.cy.js

There are PHP Warnings:

[Sat Mar 01 15:40:30.671730 2025] [php:warn] [pid 73:tid 73] [client 10.0.0.1:60956] PHP Warning:  Undefined property: stdClass::$modified_by in /var/www/html/api/components/com_newsfeeds/src/Serializer/NewsfeedSerializer.php on line 110
[Sat Mar 01 15:40:30.671786 2025] [php:warn] [pid 73:tid 73] [client 10.0.0.1:60956] PHP Warning:  Undefined property: stdClass::$modified_by in /var/www/html/api/components/com_newsfeeds/src/Serializer/NewsfeedSerializer.php on line 111

Applying this PR and run test again:

scripts/patch 53 joomla-cms-45043
scripts/test 53 system api/com_newsfeed/NewsFeed.cy.js

The Cypress test runs now without PHP Warnings successfully 👍

avatar QuyTon QuyTon - test_item - 2 Mar 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 2 Mar 2025

I have tested this item ✅ successfully on d7cd31c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45043.

avatar QuyTon QuyTon - alter_testresult - 2 Mar 2025 - muhme: Tested successfully
avatar QuyTon QuyTon - change - 2 Mar 2025
Status Pending Ready to Commit
Labels Added: Webservices PR-5.3-dev
avatar QuyTon
QuyTon - comment - 2 Mar 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45043.

avatar laoneo laoneo - change - 5 Mar 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-03-05 07:17:41
Closed_By laoneo
Labels Added: RTC
avatar laoneo laoneo - close - 5 Mar 2025
avatar laoneo laoneo - merge - 5 Mar 2025
avatar laoneo
laoneo - comment - 5 Mar 2025

Thanks!

Add a Comment

Login with GitHub to post a comment