[#45037] - [5.3] Fix code logic in admin controllers
- Fixed in Code Base
- 28 Feb 2025
- Medium
- Build: 5.3-dev
- # 45037
- Diff
- joomdonation:fix_code_logic
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
In some of our controller classes, we have this line of code $recordId = (int) isset($data[$key]) ? $data[$key] : 0; . It is clearly we want to have int casting applied to $data[$key]. However, with the current code, int casting is actually being applied to isset($data[$key]) and it is not right. This PR fixes that wrong logic.
Testing Instructions
The change is the same for all controllers, so we will just need to test one
- Use Joomla 5.3
- Try to edit a banner, save it and make sure it is still working.
Actual result BEFORE applying this Pull Request
Works, but int casting is not applied to $data[$key] as expected
Expected result AFTER applying this Pull Request
Works, and int casting is applied properly to $data[$key] as expected
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_modules com_newsfeeds Front End |
| Labels |
Added:
PR-5.3-dev
|
||
@joomdonation You should restore @QuyTon 's test result in the issue tracker because it got lost with the branch update. You can use the "Alter test" button for that.
Thanks @richard67. I had to don that to trigger CI re-run. I now altered test result from @QuyTon
I have tested this item ✅ successfully on c5277db
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45037.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45037.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-28 17:24:05 |
| Closed_By | ⇒ | rdeutz |
I have tested this item ✅ successfully on 0fbf20c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45037.