Feeling Lucky
RTC
PR-5.3-dev
[#45033] - [5.3] Do not use the deprecated get functions in Joomla action log plugin
- Fixed in Code Base
- 9 Mar 2025
- Medium
- Build: 5.3-dev
- # 45033
- Diff
- Digital-Peak:actionlog/cmsobject
User tests: Successful: Unsuccessful:
Summary of Changes
The get function is deprecated in the CMSObject class and therefore the action log Joomla plugin should treat the items as a stdClass object in the events.
This was discovered while doing #44945.
Testing Instructions
- Upload a file
- Upload the same file again and replace it
- Create a folder
- Delete the new folder
- Delete the new file
- Check if a action log entry is made for the different actions
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
laoneo
- comment
- 1 Mar 2025
For media items is no entry in action log creates.
| Labels |
Added:
PR-5.3-dev
|
||
Fedik
- comment
- 5 Mar 2025
I have tested this item ✅ successfully on a0aa1d8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45033.
| Status | Pending | ⇒ | Ready to Commit |
Fedik
- comment
- 5 Mar 2025
r2c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45033.
| Labels |
Added:
RTC
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-09 13:16:11 |
| Closed_By | ⇒ | rdeutz |
I have tested this item ✅ successfully on d893286
I have tested this successfully.
Just want to make sure of 1 thing, the log shows:
User exlemor deleted the media Media 7 minutes ago. 2025-03-01 00:23:50 Emmanuel Lemor 88
User exlemor added new media dragonfly-revisited-2.jpg Media 8 minutes ago. 2025-03-01 00:22:54 Emmanuel Lemor 87
User exlemor added new media PBF-Receipt.pdf Media 8 minutes ago. 2025-03-01 00:22:51 Emmanuel Lemor 86
User exlemor added new media dragonfly-revisited-2.jpg Media 9 minutes ago. 2025-03-01 00:21:53 Emmanuel Lemor 85
User exlemor added new media PBF-Receipt.pdf Media 9 minutes ago. 2025-03-01 00:21:52 Emmanuel Lemor 84
but it does NOT show the Creation or Deletion of the Folder, so iIF that is normal, then great, if NOT, then the PR needs an update.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45033.