RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
27 Feb 2025

Pull Request for Issue #45007 .

Summary of Changes

check array key

Testing Instructions

run
npx cypress run --spec '.\tests\System\integration\api\com_users\Users.cy.js'

Actual result BEFORE applying this Pull Request

[24-Feb-2025 19:25:27 UTC] PHP Warning: Undefined array key "password2" in D:\repos\j51\administrator\components\com_users\src\Model\UserModel.php on line 295

Expected result AFTER applying this Pull Request

no more warning

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 27 Feb 2025
avatar alikon alikon - change - 27 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2025
Category Administration com_users
avatar alikon alikon - change - 28 Feb 2025
Labels Added: PR-5.2-dev
avatar muhme
muhme - comment - 1 Mar 2025

✅ successful tested with JBT, before applying this PR on 5.2-dev

scripts/create 52
scripts/test 52 system api/com_users/Users.cy.js 

There are two PHP Warnings:

[Sat Mar 01 15:54:09.120420 2025] [php:warn] [pid 23:tid 23] [client 10.0.0.1:58812] PHP Warning:  Undefined array key "password2" in /var/www/html/administrator/components/com_users/src/Model/UserModel.php on line 295
[Sat Mar 01 15:54:09.477295 2025] [php:warn] [pid 23:tid 23] [client 10.0.0.1:58812] PHP Warning:  Undefined array key "password2" in /var/www/html/administrator/components/com_users/src/Model/UserModel.php on line 295

Applying this PR and test again:

scripts/patch 52 joomla-cms-45030
scripts/test 52 system api/com_users/Users.cy.js 

The Cypress test runs now without PHP Warnings successfully 👍

avatar alikon alikon - change - 2 Mar 2025
Title
[5.x][cypress] php warning
[5.3][cypress] php warning
avatar alikon alikon - edited - 2 Mar 2025
avatar alikon alikon - change - 7 Mar 2025
Labels Added: PR-5.3-dev
Removed: PR-5.2-dev
avatar laoneo
laoneo - comment - 7 Mar 2025

@muhme can yo give this another test?

avatar laoneo laoneo - test_item - 7 Mar 2025 - Tested successfully
avatar laoneo
laoneo - comment - 7 Mar 2025

I have tested this item ✅ successfully on 9ea2c27

I'v logged in in a private browser window and in another one edited the user and set a new password. After save, the user got logged out in the private browser window. Did the same without setting a password, and he stayed logged in.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45030.

avatar muhme muhme - test_item - 7 Mar 2025 - Tested successfully
avatar muhme
muhme - comment - 7 Mar 2025

I have tested this item ✅ successfully on 9ea2c27

Cypress test api/com_users/Users.cy.js with JBT on current 5.3-dev: Before applying this PR there are two PHP warnings. After applaying this PR the Cypress test runs without PHP Warnings successfully. 👍


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45030.

avatar brianteeman brianteeman - test_item - 10 Mar 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Mar 2025

I have tested this item ✅ successfully on 9ea2c27


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45030.

avatar QuyTon QuyTon - change - 10 Mar 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 10 Mar 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45030.

avatar QuyTon QuyTon - change - 10 Mar 2025
Labels Added: RTC
avatar laoneo laoneo - change - 10 Mar 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-03-10 14:59:39
Closed_By laoneo
avatar laoneo laoneo - close - 10 Mar 2025
avatar laoneo laoneo - merge - 10 Mar 2025
avatar laoneo
laoneo - comment - 10 Mar 2025

Thanks!

Add a Comment

Login with GitHub to post a comment