[#4502] - Fixes for a regression introduced by #4221
- Closed
- 10 Oct 2014
- Medium
- Build: staging
- # 4502
- Diff
- smanzi:fix-#4421
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
#4221 was incorrectly using str_replace() to remove the default language code when required. As str_replace() acts globally on the subject, the language code was removed also out of context (e.g. when part of an alias).
With this PR I use instead preg_replace() with the limit of one substitution. As the /language-code/ string to be replaced appears between two slashes and just after the host name (eg. http://example.com/en/) this should guarantee the correct replacements of the language code only.
I took the occasion to make a bit of clean-up by aggregating some redundantly duplicated code
jissues-bot
- | Labels |
Added:
?
|
||
I just noticed my local copy of languagefilter.php is CR-LF terminated (à-la-windows...)
Is this a problem? Can be fixed?
It is Unix in core
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-10 17:04:24 |
@test
Fine here.