[#45008] - [5.3][ cypress] null coalescing operator
- Ready to Commit
- Medium
- Build: 5.3-dev
- # 45008
- Diff
- alikon:patch-24
User tests: Successful: Unsuccessful:
Pull Request for Issue #45006 .
Summary of Changes
null coalescing operator
Testing Instructions
run npx cypress run --spec '.\tests\System\integration\site\components\com_users\Reset.cy.js'
check php_errors.log
Actual result BEFORE applying this Pull Request
PHP Deprecated: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated in ..\components\com_users\src\Model\ResetModel.php on line 530: Passing null to parameter #1 ($datetime) of type string is deprecated in ..\components\com_users\src\Model\ResetModel.php on line 530
Expected result AFTER applying this Pull Request
no more PHP Deprecated: strtotime():
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
| Title |
|
||||||
| Labels |
Added:
PR-5.3-dev
|
||
more likely to be a php version thing than an os
I have tested this item ✅ successfully on bfe4b45
php -v
PHP 8.3.3 (cli) (built: Feb 13 2024 23:17:12) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.3.3, Copyright (c) Zend Technologies
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45008.
more likely to be a php version thing than an os
thx for your comment 👍
it sounds reasonable at first and I wonder as you used 8.3.3, I have 8.1.10 on Windows and JBT is using 8.3.11, I would expect deprecation on the highest PHP version most likely
however the point is to reproduce the problem and then see it gone after the patch 😄
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45008.
more likely to be a php version thing than an os
@brianteeman Now, I remember JBT disabling deprecated messages as they were caused the tests to fail and there were to many. Perhpas after all the fixes I can hopefully enable checking deprecated again.
| Title |
|
||||||
I have tested this item ✅ successfully on bfe4b45
Tested on Windows 11 Laragon (as the deprecation message was not reproducable on JBT (using Docker Debian 11) and not reproducable on macOS 15.3.1.
Before applying the patch problem seen:
After aplying this PR with Joomla! Patch Tester the PHP Deprecated message was no more shown.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45008.