User tests: Successful: Unsuccessful:
Pull Request for Issue #44999 .
Deprecated in mod_logged
no more Deprecated in mod_logged
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Administration |
Title |
|
out of scope of this PR
Title |
|
I have tested this item ✅ successfully on 10a9e3b
Before applying this patch tested on Windows 11 (as the deprecation message was however not reproducable on JBT):
npx cypress run --spec "tests\System\integration\install\Installation.cy.js,tests\System\integration\site\components\com_users\Registration.cy.js,tests\System\integration\site\components\com_users\Login.cy.js"
admin's Home Dashboard shows on 'Logged-in Users' the message
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in C:\laragon\www\j53\administrator\modules\mod_logged\tmpl\default.php on line 37
Clicking on "Log out" for the user with the Deprecated message produces PHP error log:
[01-Mar-2025 17:34:35 UTC] PHP Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in C:\laragon\www\j53\administrator\modules\mod_logged\tmpl\default.php on line 37
After installing this PR with git (as Joomla! Patch Tester is not usable with database installation) and running the test again:
git fetch --depth 1 origin pull/45003/head:pr-45003
git checkout pr-45003
npx cypress run --spec "tests\System\integration\install\Installation.cy.js,tests\System\integration\site\components\com_users\Registration.cy.js,tests\System\integration\site\components\com_users\Login.cy.js"
The admin's Home Dashboard deprecation message on 'Logged-in Users' is gone and no entries in PHP error log 👍
Title |
|
This fixes the module output.
I still think the session data should be removed in the cypress tests when the user is deleted