Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
24 Feb 2025

Pull Request for Issue #44999 .

Summary of Changes

Testing Instructions

  • npx cypress run --spec '.\tests\System\integration\install\Installation.cy.js'
  • npx cypress run --spec '.\tests\System\integration\site\components\com_users\Registration.cy.js'
  • npx cypress run --spec '.\tests\System\integration\site\components\com_users\Login.cy.js'
  • in your browser login to the admin
  • check your php error log

Actual result BEFORE applying this Pull Request

Deprecated in mod_logged

Expected result AFTER applying this Pull Request

no more Deprecated in mod_logged

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 24 Feb 2025
avatar alikon alikon - change - 24 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2025
Category Modules Administration
avatar alikon alikon - change - 24 Feb 2025
Title
report-only-existing-useres
report-only-existing-users
avatar alikon alikon - edited - 24 Feb 2025
avatar brianteeman
brianteeman - comment - 24 Feb 2025

This fixes the module output.

I still think the session data should be removed in the cypress tests when the user is deleted

avatar alikon
alikon - comment - 25 Feb 2025

out of scope of this PR

avatar alikon alikon - change - 25 Feb 2025
The description was changed
avatar alikon alikon - edited - 25 Feb 2025
avatar alikon alikon - change - 25 Feb 2025
Title
report-only-existing-users
[5.x][cypress] user login test - report-only-existing-users
avatar alikon alikon - edited - 25 Feb 2025
avatar alikon alikon - change - 25 Feb 2025
The description was changed
avatar alikon alikon - edited - 25 Feb 2025
avatar alikon alikon - change - 25 Feb 2025
The description was changed
avatar alikon alikon - edited - 25 Feb 2025
avatar muhme muhme - test_item - 1 Mar 2025 - Tested successfully
avatar muhme
muhme - comment - 1 Mar 2025

I have tested this item ✅ successfully on 10a9e3b

Before applying this patch tested on Windows 11 (as the deprecation message was however not reproducable on JBT):

npx cypress run --spec "tests\System\integration\install\Installation.cy.js,tests\System\integration\site\components\com_users\Registration.cy.js,tests\System\integration\site\components\com_users\Login.cy.js"

admin's Home Dashboard shows on 'Logged-in Users' the message

Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in C:\laragon\www\j53\administrator\modules\mod_logged\tmpl\default.php on line 37

Clicking on "Log out" for the user with the Deprecated message produces PHP error log:

[01-Mar-2025 17:34:35 UTC] PHP Deprecated:  htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in C:\laragon\www\j53\administrator\modules\mod_logged\tmpl\default.php on line 37

After installing this PR with git (as Joomla! Patch Tester is not usable with database installation) and running the test again:

git fetch --depth 1 origin pull/45003/head:pr-45003
git checkout pr-45003
npx cypress run --spec "tests\System\integration\install\Installation.cy.js,tests\System\integration\site\components\com_users\Registration.cy.js,tests\System\integration\site\components\com_users\Login.cy.js"

The admin's Home Dashboard deprecation message on 'Logged-in Users' is gone and no entries in PHP error log 👍


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45003.

avatar alikon alikon - change - 2 Mar 2025
Title
[5.x][cypress] user login test - report-only-existing-users
[5.3][cypress] user login test - report-only-existing-users
avatar alikon alikon - edited - 2 Mar 2025

Add a Comment

Login with GitHub to post a comment