Pending

User tests: Successful: Unsuccessful:

avatar elinw
elinw
18 Dec 2011

Finder Advanced search for Joomla!. Original code for the 1.5 extension contributed by JXtended, updated for 2.5 by Michael Babker with help from a number of others.

avatar elinw elinw - open - 18 Dec 2011
avatar elinw
elinw - comment - 18 Dec 2011

i'm sending this because Michael is in transit and I wanted to make sure it gets in on time.
The sql is updated in a way that assumes that user notes is going to be merged with the changes to sql that are in that pull request.

The sample data sql enables finder and the corresponding plugins and front end module. I'd suggest this for testing during the beta period and then a decision can be made about whether to have them enabled in the release packages.

For testing, please start by clicking on the indexer in the Finder adminstrator. This could take as long as several minutes to run. At that point the features can be tested.

avatar realityking
realityking - comment - 18 Dec 2011

I'd really like to see this one rebased as well. It makes for a much nicer to read history.

Also this contains a platform change, that one should probably first be submitted upstream.

avatar infograf768
infograf768 - comment - 20 Dec 2011

Language issues:
Back-end filters are double translated.
Take off true in
<?php echo JHtml::('select.options', JHtml::('finder.mapslist'), 'value', 'text', $this->state->get('filter.branch'), true);?>
and
<?php echo JHtml::('select.options', JHtml::('finder.statelist'), 'value', 'text', $this->state->get('filter.state'), true);?>
Remains Country an Region to deal with in Maps Manager. as 2 strings are missing:
COM_FINDER_TYPE_P_COUNTRY="Country"
COM_FINDER_TYPE_P_REGION="Region"

Front-end
Same issue: take off true in
$html .= JHtml::_('select.genericlist', $nodes, 't[]', 'class="inputbox"', 'id', 'title', $active, 'tax-' . JFilterOutput::stringUrlSafe($bv->title), true);

avatar infograf768
infograf768 - comment - 20 Dec 2011

// Activate the highlighter if enabled.
if (!empty($this->query->highlight) && $this->params->get('highlight_terms', 1)) {
JHtml::_('finder.highlighter', $this->query->highlight);
}

breaks search results here.

IT looks also, here, that starting typing for joomla for example does not any more present a list of results dropping down from the search field

avatar elinw
elinw - comment - 20 Dec 2011

JM do you mean you are not getting suggested search terms?

Chris, next time you might want to try a rebase, but all that happened is that the project cms has had tons of updates and you got them all.

The highlighter issue should be fixed now.

avatar infograf768
infograf768 - comment - 21 Dec 2011

Missing taking of 'true' line 371 of
JROOT/components/com_finder/helpers/html/filter.php

should be:
$html .= JHtml::_('select.genericlist', $nodes, 't[]', 'class="inputbox"', 'id', 'title', $active, 'tax-' . JFilterOutput::stringUrlSafe($bv->title));

In the same file change line 369 to
$html .= JText::sprintf('COM_FINDER_FILTER_BRANCH_LABEL', JText::('COMFINDER_QUERY_FILTER_BRANCH_'.$bv->title));

to be able to use the strings:
COM_FINDER_QUERY_FILTER_BRANCH_AUTHOR="author"
COM_FINDER_QUERY_FILTER_BRANCH_CATEGORY="category"
COM_FINDER_QUERY_FILTER_BRANCH_COUNTRY="country"
COM_FINDER_QUERY_FILTER_BRANCH_EVENT="event"
COM_FINDER_QUERY_FILTER_BRANCH_ISSUE="issue"
COM_FINDER_QUERY_FILTER_BRANCH_LABEL="label"
COM_FINDER_QUERY_FILTER_BRANCH_REGION="region"
COM_FINDER_QUERY_FILTER_BRANCH_TYPE="type"
etc.

I still can't get autocompletion here.

avatar infograf768
infograf768 - comment - 21 Dec 2011

Also joomla.sql not installing finder correctly here. Had to discover.

avatar infograf768
infograf768 - comment - 21 Dec 2011

Also, still missing in back-end
COM_FINDER_TYPE_P_COUNTRY="Country"
COM_FINDER_TYPE_P_REGION="Region"

avatar infograf768
infograf768 - comment - 21 Dec 2011

@test a clean install of finder-Integration Finder-Integration-joomla-cms-1611287.tar.gz
change of plugin folder (I guess) has broken the finder plugins
Indexing broken too

avatar infograf768
infograf768 - comment - 21 Dec 2011

After changing back the plugin folder to finder, all works fine here, including auto-completion.
All finder stuff is installed as should although it was decided that the plugins would be disabled by default, if I remember well. Also I see that the site module has been published.
Committer: this needs an update sql in com_admin

avatar elinw
elinw - comment - 23 Dec 2011

Committed

avatar elinw elinw - close - 23 Dec 2011
avatar wilsonge wilsonge - reference | c659259 - 12 Jun 14

Add a Comment

Login with GitHub to post a comment