RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
24 Feb 2025

Follow-Pull Request for #44875 and #44938
@joomdonation

Summary of Changes

Better use str_starts_with if a substr command (or concatenate string) comes after it

Testing Instructions

code review?

Actual result BEFORE applying this Pull Request

?

Expected result AFTER applying this Pull Request

better checked string before perform action

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 24 Feb 2025
avatar heelc29 heelc29 - change - 24 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2025
Category Administration com_associations com_cpanel com_postinstall Modules Front End Plugins
avatar joomdonation joomdonation - test_item - 25 Feb 2025 - Tested successfully
avatar joomdonation
joomdonation - comment - 25 Feb 2025

I have tested this item ✅ successfully on 7cfaf0a

Yes, it's better. Thanks @heelc29


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44998.

avatar QuyTon QuyTon - test_item - 25 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 25 Feb 2025

I have tested this item ✅ successfully on 7cfaf0a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44998.

avatar QuyTon QuyTon - change - 25 Feb 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 25 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44998.

avatar HLeithner HLeithner - close - 26 Feb 2025
avatar HLeithner HLeithner - merge - 26 Feb 2025
avatar HLeithner HLeithner - change - 26 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-26 18:05:21
Closed_By HLeithner
Labels Added: RTC
avatar HLeithner
HLeithner - comment - 26 Feb 2025

thx

Add a Comment

Login with GitHub to post a comment