RTC bug PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
23 Feb 2025

Pull Request for Issue # .

Summary of Changes

avoid warning when deleting media file/folder

Testing Instructions

set error reporting to max
delete a media file/folder
check php_errors

Actual result BEFORE applying this Pull Request

PHP Warning: Undefined property: Joomla\CMS\Object\CMSObject::$id in plugins\system\schemaorg\src\Extension\Schemaorg.php on line 545

Expected result AFTER applying this Pull Request

no more warning

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 23 Feb 2025
avatar alikon alikon - change - 23 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2025
Category Front End Plugins
avatar alikon alikon - change - 23 Feb 2025
The description was changed
avatar alikon alikon - edited - 23 Feb 2025
99c17c5 23 Feb 2025 avatar alikon cs
avatar alikon alikon - change - 23 Feb 2025
Labels Added: PR-5.3-dev
avatar QuyTon QuyTon - test_item - 23 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 23 Feb 2025

I have tested this item ✅ successfully on 99c17c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44989.

avatar muhme
muhme - comment - 24 Feb 2025

Have successfully tested this PR 👍 plus #44976 with JBT 2.1.21. Before we have 8 times a PHP Notice and 4 times a PHP Warning with Cypress test api/com_media/Files.cy.js and after that none ✅:

scripts/create 53
scripts/test system 53 api/com_media/Files.cy.js
scripts/patch 53 joomla-cms-44989 joomla-cms-44976
scripts/test system 53 api/com_media/Files.cy.js
avatar muhme
muhme - comment - 24 Feb 2025

Successfully retested this PR plus #44976: No PHP Notice and PHP Warning from api/com_media/Files.cy.js

scripts/create 53 recreate
scripts/test system 53 api/com_media/Files.cy.js
scripts/patch 53 joomla-cms-44989 joomla-cms-44976
scripts/test system 53 api/com_media/Files.cy.js
avatar QuyTon QuyTon - test_item - 24 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 24 Feb 2025

I have tested this item ✅ successfully on 3927c4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44989.

avatar viocassel viocassel - test_item - 24 Feb 2025 - Tested successfully
avatar viocassel
viocassel - comment - 24 Feb 2025

I have tested this item ✅ successfully on 3927c4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44989.

avatar QuyTon QuyTon - change - 24 Feb 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 24 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44989.

avatar laoneo laoneo - change - 24 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-24 15:36:40
Closed_By laoneo
Labels Added: RTC bug
avatar laoneo laoneo - close - 24 Feb 2025
avatar laoneo laoneo - merge - 24 Feb 2025
avatar laoneo
laoneo - comment - 24 Feb 2025

Thanks!

Add a Comment

Login with GitHub to post a comment