installation/configuration.php-dist
public $dbtype = 'mysql';
As the mysql_*
functions have been deprecated since PHP 5.5.0, is there any reason not to change this default to 'mysqli'
and also mark the JDatabaseDriverMysql
driver as deprecated? If this sounds like a good idea I can work on a PR.
Labels |
Added:
?
|
Category | ⇒ | SQL |
The code is already defaulting to MySQLi and the driver is already deprecated. So the takeaway, from my perspective, from this item is we should review the installation/configuration.php-dist
file to ensure that it's providing the right values for an installation where that file may be being copied.
ok cool. so it is just the value in the rarely used
installation/configuration.php-dist file that needsn updating
On 10 October 2014 13:24, Michael Babker notifications@github.com wrote:
The code is already defaulting to MySQLi and the driver is already
deprecated #4124. So the
takeaway, from my perspective, from this item is we should review the
installation/configuration.php-dist file to ensure that it's providing
the right values for an installation where that file may be being copied.—
Reply to this email directly or view it on GitHub
#4498 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
done @brianteeman @mbabker @robations see and comment here: #4504
Closing here as we have a PR.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-10 17:40:07 |
Labels |
Added:
?
|
As Joomla still supports php 5.3 can we do that
On 10 October 2014 11:08, Robert Churchill notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/