Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44979] - [5.2] Avoid warning when deleting media file

PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
23 Feb 2025

Pull Request for Issue # .

Summary of Changes

avoid warning when deleting media file

Testing Instructions

set error reporting to max
delete a media file
check php_errors

Actual result BEFORE applying this Pull Request

PHP Warning: Undefined property: Joomla\CMS\Object\CMSObject::$id in plugins\system\schemaorg\src\Extension\Schemaorg.php on line 545

Expected result AFTER applying this Pull Request

no more warning

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 23 Feb 2025
avatar alikon alikon - change - 23 Feb 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2025
Category ⇒ Front End Plugins
avatar alikon alikon - change - 23 Feb 2025
The description was changed
avatar alikon alikon - edited - 23 Feb 2025
avatar muhme
muhme - comment - 23 Feb 2025

Running api/com_media/Files.cy.js Cypress System test causes four warnings on line 545:

[Sun Feb 23 10:21:40.206592 2025] [php:warn] [pid 23:tid 23] [client 10.0.0.1:60234] PHP Warning:  Undefined property: Joomla\\CMS\\Object\\CMSObject::$id in /var/www/html/plugins/system/schemaorg/src/Extension/Schemaorg.php on line 545
[Sun Feb 23 10:21:40.398424 2025] [php:warn] [pid 23:tid 23] [client 10.0.0.1:60234] PHP Warning:  Undefined property: Joomla\\CMS\\Object\\CMSObject::$id in /var/www/html/plugins/system/schemaorg/src/Extension/Schemaorg.php on line 545
[Sun Feb 23 10:21:40.580113 2025] [php:warn] [pid 23:tid 23] [client 10.0.0.1:60234] PHP Warning:  Undefined property: Joomla\\CMS\\Object\\CMSObject::$id in /var/www/html/plugins/system/schemaorg/src/Extension/Schemaorg.php on line 545
[Sun Feb 23 10:21:40.768906 2025] [php:warn] [pid 23:tid 23] [client 10.0.0.1:60234] PHP Warning:  Undefined property: Joomla\\CMS\\Object\\CMSObject::$id in /var/www/html/plugins/system/schemaorg/src/Extension/Schemaorg.php on line 545

After applying this PR two warnings are gone and two still exist (now on line 550):

[Sun Feb 23 10:22:41.198897 2025] [php:warn] [pid 21:tid 21] [client 10.0.0.1:61180] PHP Warning:  Undefined property: Joomla\\CMS\\Object\\CMSObject::$id in /var/www/html/plugins/system/schemaorg/src/Extension/Schemaorg.php on line 550
[Sun Feb 23 10:22:41.503707 2025] [php:warn] [pid 21:tid 21] [client 10.0.0.1:61180] PHP Warning:  Undefined property: Joomla\\CMS\\Object\\CMSObject::$id in /var/www/html/plugins/system/schemaorg/src/Extension/Schemaorg.php on line 550
avatar alikon alikon - change - 23 Feb 2025
Labels Added: PR-5.2-dev
avatar alikon
alikon - comment - 23 Feb 2025

last 2 warning are gone now

avatar laoneo
laoneo - comment - 23 Feb 2025

Probably can line 550 be merged into 552

avatar alikon
alikon - comment - 23 Feb 2025

yes

avatar QuyTon
QuyTon - comment - 23 Feb 2025

also please combine 544 and 550.

avatar alikon
alikon - comment - 23 Feb 2025

yes
i'll do a fresh one on 5.3 as requested

avatar alikon alikon - change - 23 Feb 2025
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-02-23 16:28:59
Closed_By ⇒ alikon
avatar alikon alikon - close - 23 Feb 2025
avatar alikon
alikon - comment - 23 Feb 2025

rebased to 5.3 #44989

Add a Comment

Login with GitHub to post a comment