RTC Code Review PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
22 Feb 2025

Pull Request for Issue # .

Summary of Changes

This PR uses NullCoalescingOperatorRector rector rule to improve our modules and plugins code using ??= operator. This is done automatically by rector, no manual change included.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner, easier to read code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 22 Feb 2025
avatar joomdonation joomdonation - change - 22 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2025
Category Modules Administration Front End Plugins
avatar QuyTon QuyTon - test_item - 22 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 22 Feb 2025

I have tested this item ✅ successfully on 9763cfe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44972.

avatar joomdonation
joomdonation - comment - 27 Feb 2025

@viocassel As you are familiar with this kind of PR, could you please review this PR as well? Would love to have this final one of this kind merged. Thanks !

avatar viocassel viocassel - test_item - 27 Feb 2025 - Tested successfully
avatar viocassel
viocassel - comment - 27 Feb 2025

I have tested this item ✅ successfully on 9763cfe

👌 Yes, of course. Somehow I missed testing this PR...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44972.

avatar QuyTon QuyTon - change - 27 Feb 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 27 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44972.

avatar joomdonation
joomdonation - comment - 27 Feb 2025

Great. Thanks @viocassel !

avatar QuyTon QuyTon - change - 27 Feb 2025
Labels Added: RTC
avatar rdeutz rdeutz - close - 27 Feb 2025
avatar rdeutz rdeutz - merge - 27 Feb 2025
avatar rdeutz rdeutz - change - 27 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-27 16:56:50
Closed_By rdeutz
Labels Added: Code Review

Add a Comment

Login with GitHub to post a comment