[#44945] - [6.0] Change the media manager from CMSObject to stdClass
- Fixed in Code Base
- 17 Mar 2025
- Medium
- Build: 6.0-dev
- # 44945
- Diff
- Digital-Peak:cmsobject/media
User tests: Successful: Unsuccessful:
Summary of Changes
Change the object in the media manager for the events from object to stdClass.
Testing Instructions
- Upload a file
- Upload the same file again and replace it
- Create a folder
- Delete the new folder
- Delete the new file
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org: joomla/Manual#395
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media Front End Plugins |
Are you on Joomla 6? Because the file /administrator/components/com_media/helpers/media.php should accept \stdClass and not CMSObject
| Labels |
Added:
PR-6.0-dev
|
||
I have tested this item ✅ successfully on 06c6e04
I have successfully tested this PR :) (was on 6.0.0-alpha1-dev+pr.44735 and it worked great)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44945.
Warning after deleting a file:
PHP Warning: Undefined property: stdClass::$id in \plugins\system\schemaorg\src\Extension\Schemaorg.php on line 545
I have tested this item ✅ successfully on 06c6e04
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44945.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44945.
| Labels |
Added:
RTC
|
||
This is a hard b/c break, in the discussion yesterday we came up with a solution use the compact plugin.
Discused this today in the maintainer chat and there is no reliable and easy to maintain solution to this issue. So this change is absolute ok.
| Labels |
Added:
b/c break
|
||
| Category | Administration com_media Front End Plugins | ⇒ | Administration com_media |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-17 19:57:08 |
| Closed_By | ⇒ | Bodge-IT |
Thanks and don't forget the docu
I have tested this item 🔴 unsuccessfully on 51644be
Before apply patch If and uplaod same image it replaces original one. But after applying patch getting error
MediaHelper::getContentTypeLink(): Argument #3 ($mediaObject) must be of type Joomla\CMS\Object\CMSObject, stdClass given, called in /var/www/ttpl-rt-215-php81.local/public/joomlatest/administrator/components/com_actionlogs/src/Helper/ActionlogsHelper.php on line 254
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44945.