RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
19 Feb 2025

Pull Request for Issue # .

Summary of Changes

This PR uses StrContainsRector rule to convert our modules and plugins code to use str_contains function. It does not change any existing behavior, just make the code cleaner and easier to read. The change is done automatically by rector, no manual change included here.

Testing Instructions

Need to have code review for every single change here.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner, easier to read code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 19 Feb 2025
avatar joomdonation joomdonation - change - 19 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2025
Category Modules Front End Plugins
avatar QuyTon QuyTon - test_item - 19 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 19 Feb 2025

I have tested this item ✅ successfully on 5e552d8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44938.

avatar viocassel viocassel - test_item - 19 Feb 2025 - Tested successfully
avatar viocassel
viocassel - comment - 19 Feb 2025

I have tested this item ✅ successfully on 5e552d8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44938.

avatar QuyTon QuyTon - change - 19 Feb 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 19 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44938.

avatar HLeithner HLeithner - change - 22 Feb 2025
Labels Added: RTC
avatar HLeithner HLeithner - change - 22 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-22 09:55:01
Closed_By HLeithner
avatar HLeithner HLeithner - close - 22 Feb 2025
avatar HLeithner HLeithner - merge - 22 Feb 2025
avatar HLeithner
HLeithner - comment - 22 Feb 2025

Thanks

Add a Comment

Login with GitHub to post a comment