RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
19 Feb 2025

Pull Request for Issue # .

Summary of Changes

This PR uses StrStartsWithRector rule to convert our modules and plugins code to use str_starts_with function. It does not change any existing behavior, just make the code cleaner and easier to read.

Testing Instructions

Need to have code review for every single change here.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner, easier to read code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 19 Feb 2025
avatar joomdonation joomdonation - change - 19 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2025
Category Modules Administration Front End Plugins
avatar QuyTon QuyTon - test_item - 19 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 19 Feb 2025

I have tested this item ✅ successfully on 88947d1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44936.

avatar viocassel viocassel - test_item - 19 Feb 2025 - Tested successfully
avatar viocassel
viocassel - comment - 19 Feb 2025

I have tested this item ✅ successfully on 88947d1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44936.

avatar QuyTon QuyTon - change - 19 Feb 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 19 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44936.

avatar jikubiswal
jikubiswal - comment - 22 Feb 2025

I Have tested this succesfully and workign fine with the patch


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44936.

avatar fgsw
fgsw - comment - 22 Feb 2025

@jikubiswal Please mark in future your test result at the Issue Tracker. For this pull request its not needed as we have 2 successful test.

avatar HLeithner HLeithner - change - 22 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-22 09:50:03
Closed_By HLeithner
Labels Added: RTC
avatar HLeithner HLeithner - close - 22 Feb 2025
avatar HLeithner HLeithner - merge - 22 Feb 2025
avatar HLeithner
HLeithner - comment - 22 Feb 2025

thanks

Add a Comment

Login with GitHub to post a comment