Language Change NPM Resource Changed PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
18 Feb 2025

Pull Request for Issue # .

Summary of Changes

This pull request (PR) initializes Joomla version and code name on the 5.4-dev branch.

Testing Instructions

Code review.

Or run the following command on a git clone of this repository on a clean, current 5.4-dev branch on Linux or Windows with WSL and PHP CLI available:

php ./build/bump.php -v 5.4.0-alpha1-dev -c "Kutegemea" -d "2025-02-18 16:00"

Then check for changes e.g. with git status and sort out all replacements of __DEPLOY_VERSION__ in PHP files as these replacements should be done with the next version bump on the 5.3-dev branch.

Finally replace the remaining occurrences of "5.3" in files README.md and README.txt which were not caught by the bump.php script, which are

  • query parameters with branch name in the URls for the Drone and Appveyor badges in the README.md file
  • instructions in the README.md file to check out the 5.4-dev branch
  • link to commit history of the branch on GitHub in both files

Actual result BEFORE applying this Pull Request

Joomla version and code name on the 5.4-dev branch are the same as on the 5.3-dev branch.

Expected result AFTER applying this Pull Request

The 5.4-dev branch has the right version and a new code name.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 18 Feb 2025
avatar richard67 richard67 - change - 18 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Feb 2025
Category Repository Administration Language & Strings Installation Libraries NPM Change
avatar brianteeman brianteeman - test_item - 18 Feb 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 Feb 2025

I have tested this item ✅ successfully on b89c7a4

lgtm


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44931.

avatar brianteeman
brianteeman - comment - 18 Feb 2025

in the instructions shouldnt it be bump.php not build.php


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44931.

avatar richard67 richard67 - change - 18 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 18 Feb 2025
avatar richard67
richard67 - comment - 18 Feb 2025

in the instructions shouldnt it be bump.php not build.php

@brianteeman Ouch, yes ... Fixed it. Thanks.

avatar richard67 richard67 - change - 18 Feb 2025
Labels Added: Language Change NPM Resource Changed PR-5.4-dev
avatar richard67 richard67 - change - 18 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 18 Feb 2025
avatar richard67 richard67 - change - 18 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 18 Feb 2025
avatar QuyTon QuyTon - test_item - 18 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 18 Feb 2025

I have tested this item ✅ successfully on fb1132d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44931.

avatar brianteeman
brianteeman - comment - 18 Feb 2025

Will you be updating the bump script?

avatar richard67
richard67 - comment - 18 Feb 2025

Will you be updating the bump script?

No, I won't change that right now. Will discuss with maintainers first, sooner or later.

avatar muhme
muhme - comment - 18 Feb 2025

✅ tested succesfully

Tested before applying this PR

  • Admin home dashboard shows: "‎5.3.0-alpha4-dev"
  • System information shows: Joomla! "5.3.0-alpha4-dev Development [ Timu ] 21-January-2025 16:01 GMT"

After applying this PR:

  • Admin home dashboard shows: "‎5.4.0-alpha1-dev"

  • System information shows: Joomla! 5.4.0-alpha1-dev Development [ Kutegemea ] 18-February-2025 16:00 GMT

  • Code reviewed and links checked

avatar muhme muhme - change - 18 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-18 17:58:14
Closed_By muhme
avatar muhme muhme - close - 18 Feb 2025
avatar muhme muhme - merge - 18 Feb 2025

Add a Comment

Login with GitHub to post a comment