Why do we have to add back in all those classes, when most of it is a pretty much direct copy of the framework classes? Why can't we use the alias method? I mean, if you insist on adding back in old classes, I can understand to add the CLI class, but the rest is basically just duplicated code. I don't see why we need that.

I leave the decision up to the RM's.

For the record this one is tricker. Removing the alias from CMSInput functionally changes behavior and forces extensions to change much more of their code as a result. In this very specific case because of that I’m personally against merging this (for the record in favour of merging the other application one)

Which alias do you mean? This one? It was added in #43209 after I remove the classes in #42890 and was never in production anyway. So this pr basically restores the 5.x behavior, with the only difference that the classes are moved from libraries to the compat plugin.

I do mean that one and even though it's not in production it leads to a much bigger b/c break when the compat plugin is disabled.

getting this error The file marked for modification does not exist: plugins/behaviour/compat/src/classmap/classmap.php

I have tested this item 🔴 unsuccessfully on 88f0ecd

@tekvishal you need to test it with the code from version 6. This error has nothing to do with the current pr. Best is to use the prebuilt package.

An additional comment to @wilsonge comment about the impact. The alias is only loaded when the compat plugin is enabled anyway, so this here is no difference to the state before as both ways are only loaded when the compat plugin is enabled.

I have tested this item 🔴 unsuccessfully on 59330d8

I can NOT replicate the before Condition - without the Patch applied, there is NO error message when looking at the Articles list...

See attachment below...

Thanks for the test, I'v updated the testing instructions with another class as we have an alias for the default input class.

I have tested this item ✅ successfully on 59330d8

I have tested this successfully now (with the updated new \Joomla\CMS\Input\Json(); line). Thanks @laoneo.

FYI, for the next testers, the error will show:

An error has occurred.
0 Class "Joomla\CMS\Input\Json" not found

not A Class "Joomla\CMS\Input\Input" not found exception is thrown. as mentioned in the Testing instructions.

@exlemor you are awesome!

I have tested this item ✅ successfully on 59330d8


Thanks @laoneo.

RTC as it has 2 successful tests. But I will also add the RMDQ (release managers decision queue) label so it will be decided in the CMS Maintenance Team.

Thanks for this @laoneo and for the testers @krishnaGandhi11 & @exlemor