[#44921] - [5.3] Use ternary operator for libraries
- Fixed in Code Base
- 22 Feb 2025
- Medium
- Build: 5.3-dev
- # 44921
- Diff
- joomdonation:use_ternary_operator_for_libraries
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR uses TernaryToElvisRector rector rule to improve libraries code using ?: operator instead of ? operator, where useful. This is done automatically by rector, no manual change included.
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner, easier to read code
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Thanks Robert. That works for this specific rector PR. Normally, a PR generated by rector rule will change codes in many fields on different places, so human test it in-efficient. We would need careful code review from developers.
I have tested this item ✅ successfully on f9d46d4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44921.
I have tested this item ✅ successfully on f9d46d4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44921.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44921.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-22 09:47:21 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
RTC
PR-5.3-dev
|
||
thanks
Instead of doing code review we could test if the calendar field is still working and if default values are used.