[#44917] - [5.3] Use str_contains function for libraries code
- Fixed in Code Base
- 22 Feb 2025
- Medium
- Build: 5.3-dev
- # 44917
- Diff
- joomdonation:use_str_contains_for_libraries
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR uses StrContainsRector rule to convert our libraries code to use str_contains function. It does not change any existing behavior, just make the code cleaner and easier to read. The change is done automatically by rector, no manual change included here.
Testing Instructions
Need to have code review for every single change here.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner, easier to read code.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.3-dev
|
||
Appears to be working correctly. Drone fails with phpstan complaining about code that's using deprecated features. Not sure I know enough to pass this but I think it tests okay.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44917.
I have not tested this item.
@tekvishal Maybe you have not marked your test result as "successfully" or "unsuccessfully"?
| Labels |
Added:
Code Review
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-22 09:51:22 |
| Closed_By | ⇒ | HLeithner |
thanks
I have tested this item ✅ successfully on 65f955d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44917.