[#44909] - [6.0] Remove usage of LegacyPropertyManagementTrait from Table class
- Pending
- Medium
- Build: 6.0-dev
- # 44909
- Diff
- Hackwar:6.0-table-propertytrait
User tests: Successful: Unsuccessful:
Summary of Changes
This PR was first aimed at removing the LegacyPropertyManagementTrait entirely, but it is so widely used, that it is not realistic to do so for 6.0. So now this only removes the usage of the trait for the Table class in the core. The code from the trait has been deprecated since Joomla 3.4.0, even though it has been moved around and with Joomla 4.0 has finally ended up in the legacy trait. From my perspective, it is time to do this after 11 years of it being deprecated: https://github.com/joomla/joomla-cms/blob/3.4.0/libraries/joomla/object/object.php
The trait should be removed with Joomla 8.0 definitely.
Testing Instructions
Codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder com_languages com_menus com_modules com_plugins com_templates com_users com_workflow Front End com_contact com_content com_tags Libraries |
| Labels |
Added:
PR-6.0-dev
Code Review
|
||
| Category | Administration com_finder com_languages com_menus com_modules com_plugins com_templates com_users com_workflow Front End com_contact com_content com_tags Libraries | ⇒ | Administration com_finder com_languages com_menus com_modules com_plugins com_templates com_users com_workflow Front End com_contact com_content com_tags Libraries Unit Tests |
| Labels |
Added:
Unit/System Tests
|
||
| Category | Administration com_finder com_languages com_menus com_modules com_plugins com_templates com_users com_workflow Front End com_contact com_content com_tags Libraries Unit Tests | ⇒ | Administration com_finder com_languages com_menus com_modules com_plugins com_users com_workflow Front End com_contact com_content com_tags Libraries Unit Tests |
| Category | Administration com_finder com_languages com_menus com_modules com_plugins com_users com_workflow Front End com_contact com_content com_tags Libraries Unit Tests | ⇒ | Administration com_finder com_languages com_menus com_modules com_plugins com_users com_workflow Front End com_contact com_content com_tags Libraries Plugins Unit Tests |
| Title |
|
||||||
@Hackwar code review is not enough, you please write test instruction, in this case test all touched table/model classes
from code review it's ok