Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44909] - [7.0] Remove usage of LegacyPropertyManagementTrait from Table class

Feature Unit/System Tests b/c break Removal Code Review PR-7.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
14 Feb 2025

Summary of Changes

This PR was first aimed at removing the LegacyPropertyManagementTrait entirely, but it is so widely used, that it is not realistic to do so for 6.0. So now this only removes the usage of the trait for the Table class in the core. The code from the trait has been deprecated since Joomla 3.4.0, even though it has been moved around and with Joomla 4.0 has finally ended up in the legacy trait. From my perspective, it is time to do this after 11 years of it being deprecated: https://github.com/joomla/joomla-cms/blob/3.4.0/libraries/joomla/object/object.php

The trait should be removed with Joomla 8.0 definitely.

Testing Instructions

Codereview.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#615

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 14 Feb 2025
avatar Hackwar Hackwar - change - 14 Feb 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2025
Category ⇒ Administration com_finder com_languages com_menus com_modules com_plugins com_templates com_users com_workflow Front End com_contact com_content com_tags Libraries
avatar Hackwar Hackwar - change - 19 Feb 2025
Labels Added: PR-6.0-dev Code Review
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2025
Category Administration com_finder com_languages com_menus com_modules com_plugins com_templates com_users com_workflow Front End com_contact com_content com_tags Libraries ⇒ Administration com_finder com_languages com_menus com_modules com_plugins com_templates com_users com_workflow Front End com_contact com_content com_tags Libraries Unit Tests
avatar Hackwar Hackwar - change - 19 Feb 2025
Labels Added: Unit/System Tests
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2025
Category Administration com_finder com_languages com_menus com_modules com_plugins com_templates com_users com_workflow Front End com_contact com_content com_tags Libraries Unit Tests ⇒ Administration com_finder com_languages com_menus com_modules com_plugins com_users com_workflow Front End com_contact com_content com_tags Libraries Unit Tests
avatar HLeithner
HLeithner - comment - 7 May 2025

@Hackwar code review is not enough, you please write test instruction, in this case test all touched table/model classes

from code review it's ok

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2025
Category Administration com_finder com_languages com_menus com_modules com_plugins com_users com_workflow Front End com_contact com_content com_tags Libraries Unit Tests ⇒ Administration com_finder com_languages com_menus com_modules com_plugins com_users com_workflow Front End com_contact com_content com_tags Libraries Plugins Unit Tests
avatar Hackwar Hackwar - change - 8 May 2025
Title
…
[6.0] Remove LegacyPropertyManagementTrait from Table class
[6.0] Remove usage of LegacyPropertyManagementTrait from Table class
avatar Hackwar Hackwar - edited - 8 May 2025
avatar Hackwar Hackwar - change - 8 May 2025
The description was changed
avatar Hackwar Hackwar - edited - 8 May 2025
avatar Hackwar Hackwar - change - 28 Feb 2026
Title
…
[6.0] Remove usage of LegacyPropertyManagementTrait from Table class
[7.0] Remove usage of LegacyPropertyManagementTrait from Table class
avatar Hackwar Hackwar - edited - 28 Feb 2026
avatar Hackwar Hackwar - change - 10 Mar 2026
Labels Added: bug PR-7.0-dev
avatar Hackwar Hackwar - change - 20 Apr 2026
Labels Added: Feature b/c break Removal
Removed: bug PR-6.0-dev
avatar Hackwar Hackwar - change - 20 Apr 2026
The description was changed
avatar Hackwar Hackwar - edited - 20 Apr 2026

Add a Comment

Login with GitHub to post a comment