RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
13 Feb 2025

Pull Request for Issue # .

Summary of Changes

This PR uses ListToArrayDestructRector rector rule to change code form using list function to user more modern array destruct syntax in our components code. This is done automatically by rector, no manual change included.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner code using modern syntax

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 13 Feb 2025
avatar joomdonation joomdonation - change - 13 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2025
Category Administration com_associations com_banners com_contact com_content com_fields com_media com_menus com_newsfeeds com_tags com_workflow Front End
avatar joomdonation joomdonation - change - 14 Feb 2025
Labels Added: PR-5.3-dev
avatar joomdonation joomdonation - change - 14 Feb 2025
Title
[5.3] Use list to array destruct rector for components code
[5.3] Change list to array destruct rector for components code
avatar joomdonation joomdonation - edited - 14 Feb 2025
avatar joomdonation joomdonation - change - 14 Feb 2025
Title
[5.3] Change list to array destruct rector for components code
[5.3] Change list to array destruct for components code
avatar joomdonation joomdonation - edited - 14 Feb 2025
avatar QuyTon QuyTon - test_item - 14 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 14 Feb 2025

I have tested this item โœ… successfully on 95b797e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44893.

avatar alikon alikon - test_item - 14 Feb 2025 - Tested successfully
avatar alikon
alikon - comment - 14 Feb 2025

I have tested this item โœ… successfully on 95b797e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44893.

avatar alikon alikon - change - 14 Feb 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 14 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44893.

avatar LadySolveig LadySolveig - change - 15 Feb 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-15 23:42:08
Closed_By LadySolveig
Labels Added: RTC
avatar LadySolveig LadySolveig - close - 15 Feb 2025
avatar LadySolveig LadySolveig - merge - 15 Feb 2025
avatar LadySolveig
LadySolveig - comment - 15 Feb 2025

Thank you @joomdonation and also for your reviews @alikon and @QuyTon ๐Ÿ’š

Add a Comment

Login with GitHub to post a comment