[#44888] - [5.3] Update npm dependency "joomla-ui-custom-elements" from 0.2.0 to 0.4.1
- Fixed in Code Base
- 14 Mar 2025
- Medium
- Build: 5.2-dev
- # 44888
- Diff
- richard67:5.2-dev-npm-update-joomla-ui-custom-elements-0-4-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #44831 .
Summary of Changes
This pull request (PR) updates the npm dependency "joomla-ui-custom-elements" from version "v0.2.0" to version "0.4.1" and adapts file build/media_source/templates/administrator/atum/scss/vendor/joomla-custom-elements/joomla-tab.scss to the changes from joomla-projects/custom-elements#244 .
List of all changes: joomla-projects/custom-elements@v0.2.0...0.4.1
Besides changes like code style or removal of old, obsolete "webkit-" prefixed stuff, the update contains 2 bug fixes for tabs:
- joomla-projects/custom-elements#241
- joomla-projects/custom-elements#242
and
joomla-projects/custom-elements#244
for fixing #44831
Testing Instructions
Verify that tabs in backend forms like e.g. article edit work as well as before and that there are no visual differences with and without this PR.
Verify issue #44831 .
Verify that alerts (frontend or backend doesn't matter) work as well as before and that there are no visual differences with and without this PR.
Actual result BEFORE applying this Pull Request
Tabs and alerts are working, but the tabs are using the the wrong aria-attributes for the tab-buttons and the tabindex for the button is is not set (issue #44831 ).
Expected result AFTER applying this Pull Request
Tabs and alerts are working, and issue #44831 is fixed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change |
no right now i don't have a "screen reader" in my current setup i hope the issue opener will test that scenario
i hope the issue opener will test that scenario
I hope that, too ... since 1 month.
| Labels |
Added:
a11y
NPM Resource Changed
bug
PR-5.2-dev
|
||
i know your pain , fire and forget it's a common practice unfortunately
| Title |
|
||||||
I've pinged her in Mattermost, maybe that helps.
for this reason I have always proposed to close the issues that do not receive updates in let me say for example in 2 weeks, with a bot, but as usual my proposals fall on deaf ears
I have tested this item ✅ successfully on 3e6854e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44888.
I have tested this item 🔴 unsuccessfully on 3e6854e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44888.
Active tab styling missing
Before
After
| Labels |
Added:
PR-5.3-dev
Removed: PR-5.2-dev |
||
| Category | NPM Change | ⇒ | Repository NPM Change |
I have tested this item ✅ successfully on eb566af
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44888.
Sorry for the first wrongly successful test...
And here's the VoiceOver test:
Screen.Recording.2025-03-14.at.11.09.41.mov
Sorry it took a while. First of all, everything works as desired. The negative tabindex on the tab panel prevents the panel itself from being jumped to. The tab key takes you directly to the first element within the respective panel. This is fine and correct. As long as the panel itself has no name, it cannot be jumped to. The negative tabindex is a kind of safe double bottom that saves the screen reader an empty intermediate step if a name is available. Tested with Jaws on windows
I have tested this item ✅ successfully on eb566af
Alle fine
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44888.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44888.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-14 13:27:49 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
RTC
|
||
Thanks!
i'm a little bit confused this pr shouldn't be on 5.3 ?
btw
i've tested on a 5.3 branch and i've not discovered glitch