[#44885] - [5.4] Remove pointless boolean expressions
- Fixed in Code Base
- 13 Apr 2025
- Medium
- Build: 5.3-dev
- # 44885
- Diff
- janschoenherr:patch-29
User tests: Successful: Unsuccessful:
Remove pointless boolean expressions reported by PhpStorm inspections.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_categories com_config com_content com_finder com_installer com_menus com_redirect com_tags com_templates Modules Front End com_contact com_users Layout Libraries |
| Labels |
Added:
PR-5.3-dev
|
||
| Labels |
Added:
Code Review
|
||
I have tested this item ✅ successfully on ec8cc4b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.
@janschoenherr Please fix conflicts. Thanks!
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.
| Labels |
Added:
RTC
|
||
Thanks @joomdonation for the code review, I agree that's the way to go.
| Status | Ready to Commit | ⇒ | Pending |
| Labels |
Added:
Updates Requested
RMDQ
Removed: RTC |
||
| Category | Administration com_associations com_categories com_config com_content com_finder com_installer com_menus com_redirect com_tags com_templates Modules Front End com_contact com_users Layout Libraries | ⇒ | Administration com_associations com_categories com_checkin com_config com_contact com_content com_contenthistory com_cpanel com_fields com_finder com_installer com_joomlaupdate com_menus com_modules com_postinstall com_redirect com_tags |
| Category | Administration com_associations com_categories com_config com_content com_finder com_installer com_menus com_redirect com_tags com_contact com_checkin com_contenthistory com_cpanel com_fields com_joomlaupdate com_modules com_postinstall | ⇒ | Administration com_associations com_categories com_config com_content com_finder com_installer com_menus com_redirect com_tags com_templates Modules Front End com_contact com_users Layout Libraries |
@janschoenherr There are still some other code changes which I suggested for the PR. Could you please review these suggestions as well and commit these changes if you agree so that we can move forward? Thanks.
I have tested this item ✅ successfully on 819b43d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.
@janschoenherr Could you please undo the change you made to this file administrator/components/com_categories/src/Field/CategoryeditField.php ? I made a separate with further clean up to that class #45116 . Also, look at some code suggestions from @QuyTon to fix the code style. After that, I think we are done with this PR.
| Labels |
Removed:
Updates Requested
|
||
I have tested this item ✅ successfully on 3bf56c2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.
I have tested this item ✅ successfully on 3bf56c2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.
| Labels |
Added:
RTC
|
||
| Labels |
Added:
Feature
|
||
| Category | Administration com_associations com_categories com_config com_content com_finder com_installer com_menus com_redirect com_tags com_contact com_templates Modules Front End com_users Layout Libraries | ⇒ | Administration com_admin com_associations com_categories com_config com_content com_finder com_installer com_menus com_redirect com_tags com_templates Modules Front End com_contact com_users Layout Libraries |
| Title |
|
||||||
As agreed today in the maintainers meeting, I've rebased this PR to 5.4-dev.
| Labels |
Added:
PR-5.4-dev
|
||
| Category | Administration com_associations com_categories com_config com_content com_finder com_installer com_menus com_redirect com_tags com_contact com_templates Modules Front End com_users Layout Libraries com_admin | ⇒ | Administration com_associations com_categories com_config com_content com_finder com_installer com_menus com_redirect com_tags com_templates Modules Front End com_contact com_users Layout Libraries |
I really like the improvements work as done in this pr. Unfortunately I fear that it might lead to regressions when that amount of files are touched. If possible it should be split into smaller pieces. When it still is intended to be merged as a whole, then this should be done very early in the 5.4 release cycle to iron out potential regressions. Just my 2cent's.
| Labels |
Removed:
RMDQ
PR-5.3-dev
|
||
Thanks all
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-04-13 11:24:47 |
| Closed_By | ⇒ | muhme |
I have tested this item ✅ successfully on 196f28d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.