[#4488] - Regression: We can't remove the URL-Parameter "limitstart"
- Closed
- 10 Oct 2014
- Medium
- Build: staging
- # 4488
- Diff
- Bakual:RevertLimitstartRemoval
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue
In some extensions the user can't get back to the first page once he navigated to a later page.
To my knowledge this doesn't happen in core extensions but other extensions have this reported.
It only happens when SEF URLs are enabled.
Explanation
If an extension uses JModelList::populateState(), the start of the pagination (limitstart) is stored in the session (userstate). That means the value is only changed if the limitstart parameter is present in the request. Due to a recent change (#3725) the limitstart was removed from the request when it was equal to zero. While this works for some extensions that don't use the userstates (like the core extensions), it broke pagination for the extensions which use those session states.
Solution
This PR just reverts the faulty PR and restores the limitstart parameter.
Testing
As this doesn't happen with core extensions, you need to use a 3rd party extension which is affected. You can use my own "SermonSpeaker" to do that. Either install it using the webinstaller or get it from http://www.sermonspeaker.net/download/sermonspeaker-component/sermonspeaker-component-5-2-3.html.
Create multiple sermons (batch copy the existing example sermon) and a menu item and test the pagination.
Make sure you have SEF URLs turned on as non-SEF URLs are not affected.
Votes
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | SEF |
@test it's all right for me with Kunena
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4488.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Setting to RTC as we have three tests.
zero-24
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-10 15:10:11 |
This "fix" means, that now the first page of every list has 2 URLs. "whatever" and "whatever?limitstart=0". At the same time, limitstart was always renamed to start in our URLs. please revert this. It is not the solution to the problem. The problem is in the code in JModelList::populateState().
| Labels |
Removed:
?
|
||
Tested on a fresh install of 3.3.6 with limit set to 5. 10 articles - tested for features listing and category listings with pagination and all worked fine. Installed my component with parent::populateState in the model and pagination worked fine as well. Thanks again. Cheers.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4488.