[#44868] - [5.3] Use str_starts_with function for components
- Fixed in Code Base
- 16 Feb 2025
- Medium
- Build: 5.3-dev
- # 44868
- Diff
- joomdonation:use_str_starts_with_for_components
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR uses StrStartsWithRector rule to convert code in components folder (both frontend and backend), exclude layout files to use str_starts_with function. It does not change any existing behavior, just make the code cleaner and easier to read.
I don't know if maintainers will accept this change at the state, so consider this as a demo/draft PR
Testing Instructions
As the change is applied on all components, it's hard for real test. Better to have careful code review here.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner, easier to read code.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_config com_contact com_content com_cpanel com_fields com_login com_menus com_newsfeeds com_users Front End com_wrapper |
| Labels |
Added:
PR-5.3-dev
|
||
I have tested this item ✅ successfully on cffb84f
Carefully reviewed each single change.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44868.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44868.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-16 00:15:00 |
| Closed_By | ⇒ | LadySolveig |
Thank you @joomdonation 🥳 and many thanks also to the diligent testers @QuyTon @richard67 🚀
Thank you everyone !
I have tested this item ✅ successfully on 8bdc513
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44868.