[#44852] - [5.3] Fix code style in vue files and and also exit 1 when warnings
- Fixed in Code Base
- 16 Feb 2025
- Medium
- Build: 5.3-dev
- # 44852
- Diff
- Digital-Peak:fix/vuecs
User tests: Successful: Unsuccessful:
Pull Request for Issue #44816.
Summary of Changes
Fixes the code style issues. Additionally the code style command exits with a none 0 status when warnings do happen.
Testing Instructions
Check drone javascript cs check or run the following command in the joomla root folder:
eslint --config build/.eslintrc --ignore-pattern '/media/' --ext .es6.js,.es6,.vue .
Actual result BEFORE applying this Pull Request
Warnings are displayed when running the code style check.
Expected result AFTER applying this Pull Request
No warnings when running the code style check.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
Yes
I just wanted to let drone finish as I changed the exit code. It makes no sense to close the issue when the pr would be invalid. One step after the other.
| Labels |
Added:
NPM Resource Changed
PR-5.3-dev
|
||
I have tested this item ✅ successfully on 89667cd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44852.
I have tested this item ✅ successfully on 89667cd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44852.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44852.
| Labels |
Added:
RTC
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-16 13:15:49 |
| Closed_By | ⇒ | rdeutz |
@rdeutz It seems you have merged this PR with a merge commit and not a squash commit as the commit history of the 5.3-dev branch now shows the single commits from this PR. Not a big thing as it were only 6 commits, so I see no need to revert. But I think I should at least notify you.
@laoneo Does this PR close the referred issue #44816 ?