[#44852] - [5.3] Fix code style in vue files and and also exit 1 when warnings
- Pending
- Medium
- Build: 5.3-dev
- # 44852
- Diff
- Digital-Peak:fix/vuecs
User tests: Successful: Unsuccessful:
Pull Request for Issue #44816.
Summary of Changes
Fixes the code style issues. Additionally the code style command exits with a none 0 status when warnings do happen.
Testing Instructions
Check drone javascript cs check or run the following command in the joomla root folder:
eslint --config build/.eslintrc --ignore-pattern '/media/' --ext .es6.js,.es6,.vue .
Actual result BEFORE applying this Pull Request
Warnings are displayed when running the code style check.
Expected result AFTER applying this Pull Request
No warnings when running the code style check.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
Yes
I just wanted to let drone finish as I changed the exit code. It makes no sense to close the issue when the pr would be invalid. One step after the other.
| Labels |
Added:
NPM Resource Changed
PR-5.3-dev
|
||
@laoneo Does this PR close the referred issue #44816 ?