Language Change Release Blocker PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
9 Feb 2025

Pull Request for Issue #44827 .

Summary of Changes

This pull request (PR) reverts PR #44640 , which was released with 5.3.0-alpha3.

It should be merged before 5.3.0-beta1.

Then we have all the time to find a better solution.

Important: The original issue (feature request) #44465 should be opened again when this PR gets merged.

Testing Instructions

Test 1: Update from 5.3.0-alpha3 or a current 5.3 nightly build

Update from a 5.3.0-alpha3 or a current 5.3 nightly build, which includes the PR #44640 which is reverted here, to the package created by Drone for this PR.

Check that the update succeeds.

Check that email notification by User Action Logs works in the same way as before PR #44640 was merged.

Test 2: Update from 5.3.0-alpha2 or older

Update from a 5.3.0-alpha2 or older version, which does not include the PR #44640 which is reverted here, to the package created by Drone for this PR.

Check that the update succeeds.

Check that email notification by User Action Logs works in the same way as before the update.

Test 3: New installation

This test is mainly executed by our system tests in Drone.

You just have to verify by code review that the change made by this PR here in files installation/sql/mysql/extensions.sql and administrator/components/com_admin/sql/updates/postgresql/5.3.0-2024-12-19.sql reverts the change from PR #44640 , and check that system tests in Drone do not fail at making a new installation so there is no SQL syntax error due to some typo in these files.

Actual result BEFORE applying this Pull Request

Not applicable.

Expected result AFTER applying this Pull Request

Test 1: Update from 5.3.0-alpha3 or a current 5.3 nightly build

Updating from 5.3.0-alpha3 or a current 5.3 nightly build, which both include the PR #44640 which is reverted here, to the package created by Drone for this PR works.

The database column exclude_self has been removed from table #__action_logs_users after the update.

The option "Exclude Self" has been removed from the "User Actions Log Options" settings of users.

All changes from PR #44640 have been reverted, except of the update SQL scripts 5.3.0-2024-12-19.sql, which still exist, but the SQL statement has been commented out with reference to this PR here.

Email notification by User Action Logs works in the same way as before PR #44640 was merged.

Test 2: Update from 5.3.0-alpha2 or older

Updating from 5.3.0-alpha2 or older, which did not include PR #44640 which is reverted here, to the package created by Drone for this PR works.

Email notification by User Action Logs works as well as before the update.

Test 3: New installation

A new installation succeeds and does not contain the database column exclude_self in table #__action_logs_users.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 9 Feb 2025
avatar richard67 richard67 - change - 9 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2025
Category Administration SQL com_admin Postgresql Language & Strings Installation Front End Plugins
avatar richard67 richard67 - change - 9 Feb 2025
Labels Added: Language Change PR-5.3-dev
avatar richard67 richard67 - change - 9 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 9 Feb 2025
avatar richard67 richard67 - change - 9 Feb 2025
Title
[5.3] Completely revert PR #44640 - [5.3][com_actionlogs] exclude self from mail notification
[5.3] Completely revert PR 44640 - [5.3][com_actionlogs] exclude self from mail notification
avatar richard67 richard67 - edited - 9 Feb 2025
avatar richard67 richard67 - change - 9 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 9 Feb 2025
avatar richard67
richard67 - comment - 12 Feb 2025

We have discussed the issue and my 2 alternatives in the CMS Maintenance Team's weekly meeting and decided to use this PR here to completely revert PR #44640 before 5.3.0-beta1. Then we have all the time to work on a better solution.

avatar richard67 richard67 - change - 12 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 12 Feb 2025
avatar richard67 richard67 - change - 12 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 12 Feb 2025
avatar richard67 richard67 - change - 12 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 12 Feb 2025
avatar richard67 richard67 - change - 12 Feb 2025
Labels Added: Release Blocker
avatar richard67 richard67 - change - 12 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 12 Feb 2025
avatar richard67 richard67 - change - 12 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 12 Feb 2025

Add a Comment

Login with GitHub to post a comment