User tests: Successful: 0 Unsuccessful: 0
Pull Request for Issue # .
While review code of the already merged PR #43426, I found a small issue with the code. The onContentPrepareForm
method of ConfirmConsent
class should not return boolean value, it should return void instead, like in the System - Fields plugin code https://github.com/joomla/joomla-cms/blob/5.3-dev/plugins/system/fields/src/Extension/Fields.php#L247
In general, when converting our plugins to use SubscriberInterface
, the event listeners should always return void. If we need to pass result back, use $event->addResult
method instead of return command
Code review should be enough
Works
Works
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-04 15:45:41 |
Closed_By | ⇒ | laoneo | |
Labels |
Added:
PR-5.3-dev
|
Thank you!