PR-5.3-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar joomdonation
joomdonation
4 Feb 2025

Pull Request for Issue # .

Summary of Changes

While review code of the already merged PR #43426, I found a small issue with the code. The onContentPrepareForm method of ConfirmConsent class should not return boolean value, it should return void instead, like in the System - Fields plugin code https://github.com/joomla/joomla-cms/blob/5.3-dev/plugins/system/fields/src/Extension/Fields.php#L247

In general, when converting our plugins to use SubscriberInterface, the event listeners should always return void. If we need to pass result back, use $event->addResult method instead of return command

Testing Instructions

Code review should be enough

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 4 Feb 2025
avatar joomdonation joomdonation - change - 4 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Feb 2025
Category Front End Plugins
avatar laoneo
laoneo - comment - 4 Feb 2025

Thank you!

avatar laoneo laoneo - change - 4 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-04 15:45:41
Closed_By laoneo
Labels Added: PR-5.3-dev
avatar laoneo laoneo - close - 4 Feb 2025
avatar laoneo laoneo - merge - 4 Feb 2025
avatar joomdonation
joomdonation - comment - 4 Feb 2025

Thanks @laoneo for the quick merge !

Add a Comment

Login with GitHub to post a comment