User tests: Successful: 0 Unsuccessful: 0
3.1.3
to 4.0.3
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
CC: @brianteeman
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings NPM Change Front End Plugins |
Labels |
Added:
Language Change
NPM Resource Changed
PR-5.3-dev
|
Title |
|
The main question would be for upgraded sites what happens to any options that were set and are no longer present
I think the only impact would be for any websites that utilize web components and an admin saved values in the "Web Components to Check" field. By removing this field, Sa11y won't check inside any web components with a shadow DOM. But if Web Components are not common within Joomla themes, this should be a non-issue.
@adamchaboryk It seems you have run npm ci
and not npm install
or npm i
, because your PR changes the package.json but not the package.lock. Therefore npm fails because inconsistency between json and lock file.
Please pull the changes from the GitHub reviews into your local branch and then run either npm install
or npm i
to update the lock file, and then add the changed lock file to this PR. Hint: It needs to run composer install
before running the npm command, if not done yet.
Thanks for the instructions, @richard67! Done!
I have successfully used the Extra Properties option but took me a while to work out the turn off checks option. If I understand it correctly then its the custom ruklesets part of the docs
If so Can I suggest that the label and description for this are changed to "Custom Rulesets" https://sa11y.netlify.app/developers/props/#customizing-rulesets
Great feedback, I think I have a better solution:
I updated both inline help descriptions to specific instructions/screenshot on the Joomla page part of my Sa11y project website:
I have tested this item ✅ successfully on 2f5fcd9
great new functionality - thanks @adamchaboryk
I have tested this item ✅ successfully on b5389f8
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-05 08:58:57 |
Closed_By | ⇒ | laoneo | |
Labels |
Added:
Documentation Required
|
Thanks!
Thanks @adamchaboryk
The main question would be for upgraded sites what happens to any options that were set and are no longer present