Composer Dependency Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
2 Feb 2025

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the indirect composer dependency "symfony/process" from version 5.4.28 to 5.4.47 in order to fix a security vulnerability advisory of high severity reported by composer audit. "symfony/process" is used only as an indirect development dependency.

When this PR is applied there are 2 security vulnerability advisories for "laminas/laminas-diactoros" remaining.

  • CVE-2023-29530 "HTTP Multiline Header Termination" (high severity):
    This is already fixed with build/composer_patches/4.4.4-2024-04-13_php-laminas-diactoros.patch so it is not relevant.
  • CVE-2022-31109 "HTTP Host Header Attack" (medium severity):
    This might not be fixable with a simple patch. Am still investigating and will do a separate PR if it is possible and this one here is already merged.

All changes of the package from 5.4.28 to 5.4.47: symfony/process@v5.4.28...v5.4.47

Release notes:

(There were no versions from 5.4.29 to 5.4.33 and 5.4.37 and 5.4.38.)

Testing Instructions

This test requires a composer version 2.4 or newer and a git clone of this repository.

For the actual result, run composer install and then composer audit in a command shell window in the root folder of your git clone on the current 4.4-dev branch of this repository.

For the expected result, run composer install and then composer audit on a branch with this PR applied.

You can create such a branch in your git clone and then check out that branch with the following commands, assuming that you have a git clone of your fork of this repository, and upstream is the remote for this repository here:

git fetch upstream pull/44807/head:test-pr-44807
git checkout test-pr-44807

If you git clone is a clone of this repository here and not of your fork, replace the upstream by origin in the first command.

After that, run

composer install
composer audit

Actual result BEFORE applying this Pull Request

composer install succeeds, no errors or warning.

composer audit result:

Found 3 security vulnerability advisories affecting 2 packages:
+-------------------+----------------------------------------------------------------------------------+
| Package           | laminas/laminas-diactoros                                                        |
| Severity          | high                                                                             |
| CVE               | CVE-2023-29530                                                                   |
| Title             | HTTP Multiline Header Termination                                                |
| URL               | https://github.com/advisories/GHSA-xv3h-4844-9h36                                |
| Affected versions | >=2.25.0,<2.25.2|>=2.24.0,<2.24.2|=2.23.0|=2.22.0|=2.21.0|=2.20.0|=2.19.0|<2.18. |
|                   | 1                                                                                |
| Reported at       | 2023-04-24T22:42:39+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
+-------------------+----------------------------------------------------------------------------------+
| Package           | laminas/laminas-diactoros                                                        |
| Severity          | medium                                                                           |
| CVE               | CVE-2022-31109                                                                   |
| Title             | Diactoros before 2.11.1 vulnerable to HTTP Host Header Attack.                   |
| URL               | https://github.com/advisories/GHSA-8274-h5jp-97vr                                |
| Affected versions | <2.11.1                                                                          |
| Reported at       | 2022-07-25T19:29:00+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
+-------------------+----------------------------------------------------------------------------------+
| Package           | symfony/process                                                                  |
| Severity          | high                                                                             |
| CVE               | CVE-2024-51736                                                                   |
| Title             | CVE-2024-51736: Command execution hijack on Windows with Process class           |
| URL               | https://symfony.com/cve-2024-51736                                               |
| Affected versions | >=2.0.0,<3.0.0|>=3.0.0,<4.0.0|>=4.0.0,<5.0.0|>=5.0.0,<5.1.0|>=5.1.0,<5.2.0|>=5.2 |
|                   | .0,<5.3.0|>=5.3.0,<5.4.0|>=5.4.0,<5.4.46|>=6.0.0,<6.1.0|>=6.1.0,<6.2.0|>=6.2.0,< |
|                   | 6.3.0|>=6.3.0,<6.4.0|>=6.4.0,<6.4.14|>=7.0.0,<7.1.0|>=7.1.0,<7.1.7               |
| Reported at       | 2024-11-05T08:00:00+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
Found 3 abandoned packages:
+--------------------------+----------------------------------------------------------------------------------+
| Abandoned Package        | Suggested Replacement                                                            |
+--------------------------+----------------------------------------------------------------------------------+
| fgrosse/phpasn1          | none                                                                             |
| php-cs-fixer/diff        | none                                                                             |
| phpunit/php-token-stream | none                                                                             |
+--------------------------+----------------------------------------------------------------------------------+

Expected result AFTER applying this Pull Request

composer install succeeds, no errors or warning.

composer audit result:

Found 2 security vulnerability advisories affecting 1 package:
+-------------------+----------------------------------------------------------------------------------+
| Package           | laminas/laminas-diactoros                                                        |
| Severity          | high                                                                             |
| CVE               | CVE-2023-29530                                                                   |
| Title             | HTTP Multiline Header Termination                                                |
| URL               | https://github.com/advisories/GHSA-xv3h-4844-9h36                                |
| Affected versions | >=2.25.0,<2.25.2|>=2.24.0,<2.24.2|=2.23.0|=2.22.0|=2.21.0|=2.20.0|=2.19.0|<2.18. |
|                   | 1                                                                                |
| Reported at       | 2023-04-24T22:42:39+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
+-------------------+----------------------------------------------------------------------------------+
| Package           | laminas/laminas-diactoros                                                        |
| Severity          | medium                                                                           |
| CVE               | CVE-2022-31109                                                                   |
| Title             | Diactoros before 2.11.1 vulnerable to HTTP Host Header Attack.                   |
| URL               | https://github.com/advisories/GHSA-8274-h5jp-97vr                                |
| Affected versions | <2.11.1                                                                          |
| Reported at       | 2022-07-25T19:29:00+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
Found 3 abandoned packages:
+--------------------------+----------------------------------------------------------------------------------+
| Abandoned Package        | Suggested Replacement                                                            |
+--------------------------+----------------------------------------------------------------------------------+
| fgrosse/phpasn1          | none                                                                             |
| php-cs-fixer/diff        | none                                                                             |
| phpunit/php-token-stream | none                                                                             |
+--------------------------+----------------------------------------------------------------------------------+

There are 2 security vulnerability advisories for "laminas/laminas-diactoros" remaining.

  • CVE-2023-29530 "HTTP Multiline Header Termination" (high severity):
    This is already fixed with build/composer_patches/4.4.4-2024-04-13_php-laminas-diactoros.patch so it is not relevant.
  • CVE-2022-31109 "HTTP Host Header Attack" (medium severity):
    This might not be fixable with a simple patch. Am still investigating and will do a separate PR if it is possible and this one here is already merged.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 2 Feb 2025
avatar richard67 richard67 - change - 2 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2025
Category External Library Composer Change
avatar richard67 richard67 - change - 2 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 2 Feb 2025
avatar richard67 richard67 - change - 2 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 2 Feb 2025
avatar richard67 richard67 - change - 2 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 2 Feb 2025
avatar richard67 richard67 - change - 2 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 2 Feb 2025
avatar richard67 richard67 - change - 2 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 2 Feb 2025
avatar laoneo
laoneo - comment - 3 Feb 2025

After applying I get:

Found 1 security vulnerability advisory affecting 1 package:
+-------------------+----------------------------------------------------------------------------------+
| Package           | web-auth/webauthn-lib                                                            |
| Severity          | medium                                                                           |
| CVE               | CVE-2024-39912                                                                   |
| Title             | The FIDO2/Webauthn Support for PHP library allows enumeration of valid usernames  |
| URL               | https://github.com/advisories/GHSA-875x-g8p7-5w27                                |
| Affected versions | >=4.5.0,<4.9.0                                                                   |
| Reported at       | 2024-07-15T16:37:49+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
Found 1 abandoned package:
+---------------------------+----------------------------------------------------------------------------------+
| Abandoned Package         | Suggested Replacement                                                            |
+---------------------------+----------------------------------------------------------------------------------+
| web-auth/metadata-service | web-auth/webauthn-lib                                                            |
+---------------------------+----------------------------------------------------------------------------------+
avatar richard67
richard67 - comment - 3 Feb 2025

@laoneo On 4.4-dev?

avatar laoneo
laoneo - comment - 3 Feb 2025

After I switched to your branch.

avatar richard67
richard67 - comment - 3 Feb 2025

@laoneo My mistake, git command in instructions did. still contain wrong PR number 44805, so you fetched my 5.2 PR. Will correct the instructions. Before testing again delete that branch.

avatar richard67 richard67 - change - 3 Feb 2025
The description was changed
avatar richard67 richard67 - edited - 3 Feb 2025
avatar richard67
richard67 - comment - 3 Feb 2025

Instructions corrected.

avatar SniperSister SniperSister - test_item - 3 Feb 2025 - Tested successfully
avatar SniperSister
SniperSister - comment - 3 Feb 2025

I have tested this item ✅ successfully on e505a74


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44807.

avatar laoneo laoneo - change - 3 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-03 10:01:04
Closed_By laoneo
Labels Added: Composer Dependency Changed PR-4.4-dev
avatar laoneo laoneo - close - 3 Feb 2025
avatar laoneo laoneo - merge - 3 Feb 2025
avatar laoneo
laoneo - comment - 3 Feb 2025

Thanks!

Add a Comment

Login with GitHub to post a comment