User tests: Successful: 2 QuyTon, fgsw Unsuccessful: 0
Pull Request for Issue #39575.
All methods and attributes in the AssociationServiceTrait are in singular, except for the getAssociationsExtension()
. In the maintainers meeting on January 8th 2025 it was decided to change this to getAssociationExtension()
.
Codereview
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
I have tested this item ✅ successfully on 8ad3410
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
PR-5.3-dev
|
RTC
Maintainers decision of today is to deprecate the old function and create a new one with right name, also updating our code base
Base on the decision above, I think this PR is incomplete:
AssociationServiceInterface
? It is still having method with old name defined.
I have tested this item ✅ successfully on 8ad3410
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44788.