PR-5.3-dev Pending

User tests: Successful: 2 QuyTon, fgsw Unsuccessful: 0

avatar Hackwar
Hackwar
27 Jan 2025

Pull Request for Issue #39575.

Summary of Changes

All methods and attributes in the AssociationServiceTrait are in singular, except for the getAssociationsExtension(). In the maintainers meeting on January 8th 2025 it was decided to change this to getAssociationExtension().

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 27 Jan 2025
avatar Hackwar Hackwar - change - 27 Jan 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2025
Category Libraries
avatar fgsw fgsw - test_item - 27 Jan 2025 - Tested successfully
avatar fgsw
fgsw - comment - 27 Jan 2025

I have tested this item ✅ successfully on 8ad3410


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44788.

avatar QuyTon QuyTon - test_item - 28 Jan 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 28 Jan 2025

I have tested this item ✅ successfully on 8ad3410


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44788.

avatar QuyTon QuyTon - change - 28 Jan 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 28 Jan 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44788.

avatar joomdonation
joomdonation - comment - 28 Jan 2025

Maintainers decision of today is to deprecate the old function and create a new one with right name, also updating our code base

Base on the decision above, I think this PR is incomplete:

  • Our code base is not updated to call new method yet
  • How about AssociationServiceInterface ? It is still having method with old name defined.

Add a Comment

Login with GitHub to post a comment