[#44788] - [5.3] AssociationServiceTrait: Fix naming inconsistency
- Pending
- Medium
- Build: 5.3-dev
- # 44788
- Diff
- Hackwar:5.3-associationservicetrait
User tests: Successful: Unsuccessful:
Pull Request for Issue #39575.
Summary of Changes
All methods and attributes in the AssociationServiceTrait are in singular, except for the getAssociationsExtension(). In the maintainers meeting on January 8th 2025 it was decided to change this to getAssociationExtension().
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item ✅ successfully on 8ad3410
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44788.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44788.
Maintainers decision of today is to deprecate the old function and create a new one with right name, also updating our code base
Base on the decision above, I think this PR is incomplete:
- Our code base is not updated to call new method yet
- How about
AssociationServiceInterface? It is still having method with old name defined.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to @joomdonation 's comment. @Hackwar Could you check that?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44788.
| Labels |
Added:
Updates Requested
|
||
I have tested this item ✅ successfully on 8ad3410
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44788.